Update name of env form

atst/forms/app_settings.py

@@ -10,6 +10,6 @@ class EnvMemberRoleForm(BaseForm):
     role = RadioField(choices=ENV_ROLES)
 
 
-class EnvironmentForm(BaseForm):
+class EnvironmentRolesForm(BaseForm):
     team_roles = FieldList(FormField(EnvMemberRoleForm))
     env_id = HiddenField()

atst/forms/data.py

@@ -217,4 +217,6 @@ REQUIRED_DISTRIBUTIONS = [
     ("other", "Other as necessary"),
 ]
 
-ENV_ROLES = [(role.value, role.value) for role in CSPRole]
+ENV_ROLES = [(role.value, role.value) for role in CSPRole] + [
+    ("No access", "No access")
+]

atst/routes/applications/settings.py

@@ -4,7 +4,7 @@ from . import applications_bp
 from atst.domain.environment_roles import EnvironmentRoles
 from atst.domain.applications import Applications
 from atst.forms.application import ApplicationForm
-from atst.forms.app_settings import EnvironmentForm
+from atst.forms.app_settings import EnvironmentRolesForm
 from atst.domain.authz.decorator import user_can_access_decorator as user_can
 from atst.models.permissions import Permissions
 from atst.utils.flash import formatted_flash as flash
@@ -49,7 +49,7 @@ def settings(application_id):
     env_data = serialize_env_member_form_data(application)
     env_forms = {}
     for data in env_data:
-        env_forms[data["env_id"]] = EnvironmentForm(data=data)
+        env_forms[data["env_id"]] = EnvironmentRolesForm(data=data)
 
     return render_template(
         "portfolios/applications/edit.html",