From f6577c0cd663d7327ead31887ae70dfc7c31afd4 Mon Sep 17 00:00:00 2001
From: leigh-mil <leigh-ctr@friends.dds.mil>
Date: Mon, 22 Apr 2019 16:56:09 -0400
Subject: [PATCH] Update name of env form

---
 atst/forms/app_settings.py           | 2 +-
 atst/forms/data.py                   | 4 +++-
 atst/routes/applications/settings.py | 4 ++--
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/atst/forms/app_settings.py b/atst/forms/app_settings.py
index 8f8d7d6e..cdc20b0d 100644
--- a/atst/forms/app_settings.py
+++ b/atst/forms/app_settings.py
@@ -10,6 +10,6 @@ class EnvMemberRoleForm(BaseForm):
     role = RadioField(choices=ENV_ROLES)
 
 
-class EnvironmentForm(BaseForm):
+class EnvironmentRolesForm(BaseForm):
     team_roles = FieldList(FormField(EnvMemberRoleForm))
     env_id = HiddenField()
diff --git a/atst/forms/data.py b/atst/forms/data.py
index a98fbc04..85826ada 100644
--- a/atst/forms/data.py
+++ b/atst/forms/data.py
@@ -217,4 +217,6 @@ REQUIRED_DISTRIBUTIONS = [
     ("other", "Other as necessary"),
 ]
 
-ENV_ROLES = [(role.value, role.value) for role in CSPRole]
+ENV_ROLES = [(role.value, role.value) for role in CSPRole] + [
+    ("No access", "No access")
+]
diff --git a/atst/routes/applications/settings.py b/atst/routes/applications/settings.py
index fe398146..46919ac4 100644
--- a/atst/routes/applications/settings.py
+++ b/atst/routes/applications/settings.py
@@ -4,7 +4,7 @@ from . import applications_bp
 from atst.domain.environment_roles import EnvironmentRoles
 from atst.domain.applications import Applications
 from atst.forms.application import ApplicationForm
-from atst.forms.app_settings import EnvironmentForm
+from atst.forms.app_settings import EnvironmentRolesForm
 from atst.domain.authz.decorator import user_can_access_decorator as user_can
 from atst.models.permissions import Permissions
 from atst.utils.flash import formatted_flash as flash
@@ -49,7 +49,7 @@ def settings(application_id):
     env_data = serialize_env_member_form_data(application)
     env_forms = {}
     for data in env_data:
-        env_forms[data["env_id"]] = EnvironmentForm(data=data)
+        env_forms[data["env_id"]] = EnvironmentRolesForm(data=data)
 
     return render_template(
         "portfolios/applications/edit.html",