pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #417 from dod-ccpo/fix-manual-fin-ver-#161560975

Browse Source 
Fix manual fin ver #161560975
This commit is contained in:
leigh-mil 2018-10-31 14:55:44 -04:00 committed by GitHub
commit 72f7a67cfc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
atst/routes/requests/financial_verification.py
View File

@ -133,7 +133,9 @@ class UpdateFinancialVerification(FinancialVerificationBase):
if not self.pe_validator.validate(self.request, form.pe_id):
should_submit = False
if not self.task_order_validator.validate(form.task_order.number):
if not self.is_extended and not self.task_order_validator.validate(
form.task_order.number
):
should_submit = False
if should_update:

11
tests/routes/test_financial_verification.py
View File

@ -122,6 +122,17 @@ def test_update_fv_extended(fv_data, e_fv_data):
assert update_fv.execute()
def test_update_fv_extended_does_not_validate_task_order(fv_data, e_fv_data):
request = RequestFactory.create()
user = UserFactory.create()
data = {**fv_data, **e_fv_data, "task_order-number": "abc123"}
update_fv = UpdateFinancialVerification(
TrueValidator, TaskOrderNumberValidator(), user, request, data, is_extended=True
)
assert update_fv.execute()
def test_update_fv_missing_extended_data(fv_data):
request = RequestFactory.create()
user = UserFactory.create()