From 38d6f3577fbf461cc580f48496817bf16bc37af0 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Mon, 29 Oct 2018 17:04:42 -0400 Subject: [PATCH 1/2] Change UpdateFinancialVerification class so that it only validates TO numbers when the form is not extended --- atst/routes/requests/financial_verification.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/atst/routes/requests/financial_verification.py b/atst/routes/requests/financial_verification.py index c578dc98..2a4d6443 100644 --- a/atst/routes/requests/financial_verification.py +++ b/atst/routes/requests/financial_verification.py @@ -133,7 +133,9 @@ class UpdateFinancialVerification(FinancialVerificationBase): if not self.pe_validator.validate(self.request, form.pe_id): should_submit = False - if not self.task_order_validator.validate(form.task_order.number): + if not self.is_extended and not self.task_order_validator.validate( + form.task_order.number + ): should_submit = False if should_update: From 968d487f6f5b30aae4c1c69b5a111d263d10e6a7 Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Wed, 31 Oct 2018 11:44:39 -0400 Subject: [PATCH 2/2] Add test --- tests/routes/test_financial_verification.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/routes/test_financial_verification.py b/tests/routes/test_financial_verification.py index 8ab8790d..cbfc959d 100644 --- a/tests/routes/test_financial_verification.py +++ b/tests/routes/test_financial_verification.py @@ -122,6 +122,17 @@ def test_update_fv_extended(fv_data, e_fv_data): assert update_fv.execute() +def test_update_fv_extended_does_not_validate_task_order(fv_data, e_fv_data): + request = RequestFactory.create() + user = UserFactory.create() + data = {**fv_data, **e_fv_data, "task_order-number": "abc123"} + update_fv = UpdateFinancialVerification( + TrueValidator, TaskOrderNumberValidator(), user, request, data, is_extended=True + ) + + assert update_fv.execute() + + def test_update_fv_missing_extended_data(fv_data): request = RequestFactory.create() user = UserFactory.create()