better domain method name for checking DD254 completeness

This commit is contained in:
dandds 2019-02-20 11:07:50 -05:00
parent 47f57351f7
commit 4521b7483f
3 changed files with 4 additions and 4 deletions

View File

@ -186,7 +186,7 @@ class DD254s:
# TODO: standin implementation until we have a real download,
# sign, and verify process for the DD 254 PDF
@classmethod
def complete(cls, dd254):
def is_complete(cls, dd254):
if dd254 is None:
return False

View File

@ -62,7 +62,7 @@ def view_task_order(portfolio_id, task_order_id):
portfolio = Portfolios.get(g.current_user, portfolio_id)
task_order = TaskOrders.get(g.current_user, task_order_id)
to_form_complete = TaskOrders.all_sections_complete(task_order)
dd_254_complete = DD254s.complete(task_order.dd_254)
dd_254_complete = DD254s.is_complete(task_order.dd_254)
return render_template(
"portfolios/task_orders/show.html",
portfolio=portfolio,

View File

@ -120,5 +120,5 @@ def test_dd254_complete():
finished = DD254Factory.create()
unfinished = DD254Factory.create(certifying_official=None)
assert DD254s.complete(finished)
assert not DD254s.complete(unfinished)
assert DD254s.is_complete(finished)
assert not DD254s.is_complete(unfinished)