From 4521b7483faa038ba66f5bda8bf9814a0508a1e9 Mon Sep 17 00:00:00 2001 From: dandds Date: Wed, 20 Feb 2019 11:07:50 -0500 Subject: [PATCH] better domain method name for checking DD254 completeness --- atst/domain/task_orders.py | 2 +- atst/routes/portfolios/task_orders.py | 2 +- tests/domain/test_task_orders.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/atst/domain/task_orders.py b/atst/domain/task_orders.py index 764cfdaa..6f43aeb3 100644 --- a/atst/domain/task_orders.py +++ b/atst/domain/task_orders.py @@ -186,7 +186,7 @@ class DD254s: # TODO: standin implementation until we have a real download, # sign, and verify process for the DD 254 PDF @classmethod - def complete(cls, dd254): + def is_complete(cls, dd254): if dd254 is None: return False diff --git a/atst/routes/portfolios/task_orders.py b/atst/routes/portfolios/task_orders.py index f9692c6d..9b27771b 100644 --- a/atst/routes/portfolios/task_orders.py +++ b/atst/routes/portfolios/task_orders.py @@ -62,7 +62,7 @@ def view_task_order(portfolio_id, task_order_id): portfolio = Portfolios.get(g.current_user, portfolio_id) task_order = TaskOrders.get(g.current_user, task_order_id) to_form_complete = TaskOrders.all_sections_complete(task_order) - dd_254_complete = DD254s.complete(task_order.dd_254) + dd_254_complete = DD254s.is_complete(task_order.dd_254) return render_template( "portfolios/task_orders/show.html", portfolio=portfolio, diff --git a/tests/domain/test_task_orders.py b/tests/domain/test_task_orders.py index d6458da1..401d2db9 100644 --- a/tests/domain/test_task_orders.py +++ b/tests/domain/test_task_orders.py @@ -120,5 +120,5 @@ def test_dd254_complete(): finished = DD254Factory.create() unfinished = DD254Factory.create(certifying_official=None) - assert DD254s.complete(finished) - assert not DD254s.complete(unfinished) + assert DD254s.is_complete(finished) + assert not DD254s.is_complete(unfinished)