pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename to Workspaces.can_revoke_access_for for clarity

Browse Source
This commit is contained in:
richard-dds 2018-11-27 15:21:37 -05:00
parent b7c7c72a34
commit f546ccb673
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
atst/domain/workspaces/workspaces.py
View File

@ -145,7 +145,7 @@ class Workspaces(object):
WorkspacesQuery.add_and_commit(workspace) WorkspacesQuery.add_and_commit(workspace)
@classmethod @classmethod
def can_revoke_access(cls, workspace, workspace_role): def can_revoke_access_for(cls, workspace, workspace_role):
return workspace_role.user != workspace.owner return workspace_role.user != workspace.owner
@classmethod @classmethod
@ -159,7 +159,7 @@ class Workspaces(object):
) )
workspace_role = WorkspaceRoles.get_by_id(workspace_role_id) workspace_role = WorkspaceRoles.get_by_id(workspace_role_id)
if not Workspaces.can_revoke_access(workspace, workspace_role): if not Workspaces.can_revoke_access_for(workspace, workspace_role):
raise WorkspaceError("cannot revoke workspace access for this user") raise WorkspaceError("cannot revoke workspace access for this user")
workspace_role.status = WorkspaceRoleStatus.DISABLED workspace_role.status = WorkspaceRoleStatus.DISABLED

4
tests/domain/test_workspaces.py
View File

@ -316,8 +316,8 @@ def test_can_revoke_access():
owner_role = workspace.roles[0] owner_role = workspace.roles[0]
workspace_role = WorkspaceRoleFactory.create(workspace=workspace) workspace_role = WorkspaceRoleFactory.create(workspace=workspace)
assert Workspaces.can_revoke_access(workspace, workspace_role) assert Workspaces.can_revoke_access_for(workspace, workspace_role)
assert not Workspaces.can_revoke_access(workspace, owner_role) assert not Workspaces.can_revoke_access_for(workspace, owner_role)
def test_cant_revoke_owner_workspace_access(): def test_cant_revoke_owner_workspace_access():