Rename to Workspaces.can_revoke_access_for for clarity
This commit is contained in:
parent
b7c7c72a34
commit
f546ccb673
@ -145,7 +145,7 @@ class Workspaces(object):
|
||||
WorkspacesQuery.add_and_commit(workspace)
|
||||
|
||||
@classmethod
|
||||
def can_revoke_access(cls, workspace, workspace_role):
|
||||
def can_revoke_access_for(cls, workspace, workspace_role):
|
||||
return workspace_role.user != workspace.owner
|
||||
|
||||
@classmethod
|
||||
@ -159,7 +159,7 @@ class Workspaces(object):
|
||||
)
|
||||
workspace_role = WorkspaceRoles.get_by_id(workspace_role_id)
|
||||
|
||||
if not Workspaces.can_revoke_access(workspace, workspace_role):
|
||||
if not Workspaces.can_revoke_access_for(workspace, workspace_role):
|
||||
raise WorkspaceError("cannot revoke workspace access for this user")
|
||||
|
||||
workspace_role.status = WorkspaceRoleStatus.DISABLED
|
||||
|
@ -316,8 +316,8 @@ def test_can_revoke_access():
|
||||
owner_role = workspace.roles[0]
|
||||
workspace_role = WorkspaceRoleFactory.create(workspace=workspace)
|
||||
|
||||
assert Workspaces.can_revoke_access(workspace, workspace_role)
|
||||
assert not Workspaces.can_revoke_access(workspace, owner_role)
|
||||
assert Workspaces.can_revoke_access_for(workspace, workspace_role)
|
||||
assert not Workspaces.can_revoke_access_for(workspace, owner_role)
|
||||
|
||||
|
||||
def test_cant_revoke_owner_workspace_access():
|
||||
|
Loading…
x
Reference in New Issue
Block a user