pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #819 from dod-ccpo/handle-none-checkbox-value

Browse Source 
Catch None values for IsNumber validator
This commit is contained in:
montana-mil 2019-05-15 11:58:22 -04:00 committed by GitHub
commit a3c808a09f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
atst/forms/validators.py
View File

@ -32,7 +32,7 @@ def IsNumber(message=translate("forms.validators.is_number_message")):
def _is_number(form, field): def _is_number(form, field):
try: try:
int(field.data) int(field.data)
except ValueError: except (ValueError, TypeError):
raise ValidationError(message) raise ValidationError(message)
return _is_number return _is_number

2
tests/forms/test_validators.py
View File

@ -17,7 +17,7 @@ class TestIsNumber:
dummy_field.data = valid dummy_field.data = valid
validator(dummy_form, dummy_field) validator(dummy_form, dummy_field)
@pytest.mark.parametrize("invalid", ["12.1", "two", ""]) @pytest.mark.parametrize("invalid", ["12.1", "two", "", None])
def test_IsNumber_rejects_anything_else(self, invalid, dummy_form, dummy_field): def test_IsNumber_rejects_anything_else(self, invalid, dummy_form, dummy_field):
validator = IsNumber() validator = IsNumber()
dummy_field.data = invalid dummy_field.data = invalid