From 86c6044ca1d98610acd34a7db722800e50773225 Mon Sep 17 00:00:00 2001 From: Montana Date: Tue, 14 May 2019 16:53:15 -0400 Subject: [PATCH] Catch None values for IsNumber validator --- atst/forms/validators.py | 2 +- tests/forms/test_validators.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atst/forms/validators.py b/atst/forms/validators.py index b6606062..ff4b2366 100644 --- a/atst/forms/validators.py +++ b/atst/forms/validators.py @@ -32,7 +32,7 @@ def IsNumber(message=translate("forms.validators.is_number_message")): def _is_number(form, field): try: int(field.data) - except ValueError: + except (ValueError, TypeError): raise ValidationError(message) return _is_number diff --git a/tests/forms/test_validators.py b/tests/forms/test_validators.py index fe12cd58..2dc80659 100644 --- a/tests/forms/test_validators.py +++ b/tests/forms/test_validators.py @@ -17,7 +17,7 @@ class TestIsNumber: dummy_field.data = valid validator(dummy_form, dummy_field) - @pytest.mark.parametrize("invalid", ["12.1", "two", ""]) + @pytest.mark.parametrize("invalid", ["12.1", "two", "", None]) def test_IsNumber_rejects_anything_else(self, invalid, dummy_form, dummy_field): validator = IsNumber() dummy_field.data = invalid