pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change "auto approve" to "auto accept" to reflect whats happening

Browse Source
This commit is contained in:
Patrick Smith 2018-11-06 17:00:45 -05:00
parent 9cb2b9714e
commit a0168a3666
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
atst/domain/requests/requests.py
View File

@ -27,7 +27,7 @@ def create_revision_from_request_body(body):
class Requests(object): class Requests(object):
AUTO_APPROVE_THRESHOLD = 1_000_000 AUTO_ACCEPT_THRESHOLD = 1_000_000
ANNUAL_SPEND_THRESHOLD = 1_000_000 ANNUAL_SPEND_THRESHOLD = 1_000_000
@classmethod @classmethod
@ -63,7 +63,7 @@ class Requests(object):
def submit(cls, request): def submit(cls, request):
request = Requests.set_status(request, RequestStatus.SUBMITTED) request = Requests.set_status(request, RequestStatus.SUBMITTED)
if Requests.should_auto_approve(request): if Requests.should_auto_accept(request):
request = Requests.set_status( request = Requests.set_status(
request, RequestStatus.PENDING_FINANCIAL_VERIFICATION request, RequestStatus.PENDING_FINANCIAL_VERIFICATION
) )
@ -134,13 +134,13 @@ class Requests(object):
return updated_request return updated_request
@classmethod @classmethod
def should_auto_approve(cls, request): def should_auto_accept(cls, request):
try: try:
dollar_value = request.body["details_of_use"]["dollar_value"] dollar_value = request.body["details_of_use"]["dollar_value"]
except KeyError: except KeyError:
return False return False
return dollar_value < cls.AUTO_APPROVE_THRESHOLD return dollar_value < cls.AUTO_ACCEPT_THRESHOLD
_VALID_SUBMISSION_STATUSES = [ _VALID_SUBMISSION_STATUSES = [
RequestStatus.STARTED, RequestStatus.STARTED,

2
atst/forms/new_request.py
View File

@ -35,7 +35,7 @@ class DetailsOfUseForm(ValidatedForm):
except ValueError: except ValueError:
annual_spend = 0 annual_spend = 0
if annual_spend > Requests.AUTO_APPROVE_THRESHOLD: if annual_spend > Requests.AUTO_ACCEPT_THRESHOLD:
self.number_user_sessions.validators.append(InputRequired()) self.number_user_sessions.validators.append(InputRequired())
self.average_daily_traffic.validators.append(InputRequired()) self.average_daily_traffic.validators.append(InputRequired())