From a0168a3666ef3c9b57a1806e8924c69c4e44a1ce Mon Sep 17 00:00:00 2001 From: Patrick Smith Date: Tue, 6 Nov 2018 17:00:45 -0500 Subject: [PATCH] Change "auto approve" to "auto accept" to reflect whats happening --- atst/domain/requests/requests.py | 8 ++++---- atst/forms/new_request.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/atst/domain/requests/requests.py b/atst/domain/requests/requests.py index 29f3b526..855328d0 100644 --- a/atst/domain/requests/requests.py +++ b/atst/domain/requests/requests.py @@ -27,7 +27,7 @@ def create_revision_from_request_body(body): class Requests(object): - AUTO_APPROVE_THRESHOLD = 1_000_000 + AUTO_ACCEPT_THRESHOLD = 1_000_000 ANNUAL_SPEND_THRESHOLD = 1_000_000 @classmethod @@ -63,7 +63,7 @@ class Requests(object): def submit(cls, request): request = Requests.set_status(request, RequestStatus.SUBMITTED) - if Requests.should_auto_approve(request): + if Requests.should_auto_accept(request): request = Requests.set_status( request, RequestStatus.PENDING_FINANCIAL_VERIFICATION ) @@ -134,13 +134,13 @@ class Requests(object): return updated_request @classmethod - def should_auto_approve(cls, request): + def should_auto_accept(cls, request): try: dollar_value = request.body["details_of_use"]["dollar_value"] except KeyError: return False - return dollar_value < cls.AUTO_APPROVE_THRESHOLD + return dollar_value < cls.AUTO_ACCEPT_THRESHOLD _VALID_SUBMISSION_STATUSES = [ RequestStatus.STARTED, diff --git a/atst/forms/new_request.py b/atst/forms/new_request.py index c1b3e14d..b5ea8d5c 100644 --- a/atst/forms/new_request.py +++ b/atst/forms/new_request.py @@ -35,7 +35,7 @@ class DetailsOfUseForm(ValidatedForm): except ValueError: annual_spend = 0 - if annual_spend > Requests.AUTO_APPROVE_THRESHOLD: + if annual_spend > Requests.AUTO_ACCEPT_THRESHOLD: self.number_user_sessions.validators.append(InputRequired()) self.average_daily_traffic.validators.append(InputRequired())