environment role deletion method should also return a bool
This commit is contained in:
parent
a75c19188f
commit
8754a74613
@ -21,3 +21,6 @@ class EnvironmentRoles(object):
|
||||
if existing_env_role:
|
||||
db.session.delete(existing_env_role)
|
||||
db.session.commit()
|
||||
return True
|
||||
else:
|
||||
return False
|
||||
|
@ -72,8 +72,11 @@ class Environments(object):
|
||||
environment = Environments.get(id_and_role["id"])
|
||||
|
||||
if new_role is None:
|
||||
EnvironmentRoles.delete(workspace_role.user.id, environment.id)
|
||||
updated = True
|
||||
role_deleted = EnvironmentRoles.delete(
|
||||
workspace_role.user.id, environment.id
|
||||
)
|
||||
if role_deleted:
|
||||
updated = True
|
||||
else:
|
||||
env_role = EnvironmentRoles.get(
|
||||
workspace_role.user.id, id_and_role["id"]
|
||||
|
Loading…
x
Reference in New Issue
Block a user