From 8754a74613fcf27f226a47b9994c131cd88dd8b4 Mon Sep 17 00:00:00 2001 From: dandds Date: Wed, 12 Dec 2018 11:57:54 -0500 Subject: [PATCH] environment role deletion method should also return a bool --- atst/domain/environment_roles.py | 3 +++ atst/domain/environments.py | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/atst/domain/environment_roles.py b/atst/domain/environment_roles.py index 5c0be864..18d056f1 100644 --- a/atst/domain/environment_roles.py +++ b/atst/domain/environment_roles.py @@ -21,3 +21,6 @@ class EnvironmentRoles(object): if existing_env_role: db.session.delete(existing_env_role) db.session.commit() + return True + else: + return False diff --git a/atst/domain/environments.py b/atst/domain/environments.py index 760d620a..b3b42d9f 100644 --- a/atst/domain/environments.py +++ b/atst/domain/environments.py @@ -72,8 +72,11 @@ class Environments(object): environment = Environments.get(id_and_role["id"]) if new_role is None: - EnvironmentRoles.delete(workspace_role.user.id, environment.id) - updated = True + role_deleted = EnvironmentRoles.delete( + workspace_role.user.id, environment.id + ) + if role_deleted: + updated = True else: env_role = EnvironmentRoles.get( workspace_role.user.id, id_and_role["id"]