pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve integration test: no monkeypatching, assert request is submitted

Browse Source
This commit is contained in:
dandds 2018-08-13 10:58:05 -04:00
parent 1eb8e79f41
commit 7e4723452c
1 changed files with 33 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
tests/test_integration.py
View File

@ -1,37 +1,38 @@
import pytest import pytest
from .factories import UserFactory from urllib.parse import urlencode
from .factories import UserFactory, RequestFactory
from atst.routes.requests.jedi_request_flow import JEDIRequestFlow from atst.routes.requests.jedi_request_flow import JEDIRequestFlow
from atst.models.request_status_event import RequestStatus
from atst.domain.requests import Requests
@pytest.fixture @pytest.fixture
def screens(app): def screens(app):
return JEDIRequestFlow(3).screens return JEDIRequestFlow(3).screens
def test_stepthrough_request_form(monkeypatch, user_session, screens, client): def test_stepthrough_request_form(user_session, screens, client):
user = UserFactory.create() user = UserFactory.create()
user_session(user) user_session(user)
mock_request = RequestFactory.stub()
monkeypatch.setattr( def post_form(url, redirects=False, data=""):
"atst.routes.requests.jedi_request_flow.JEDIRequestFlow.validate", lambda s: True return client.post(
)
def post_form(url, redirects=False):
return client.post(
url, url,
headers={"Content-Type": "application/x-www-form-urlencoded"}, headers={"Content-Type": "application/x-www-form-urlencoded"},
data="meaning=42", data=data,
follow_redirects=redirects follow_redirects=redirects,
) )
def take_a_step(inc, req=None, data=None):
def take_a_step(inc, req=None):
req_url = "/requests/new/{}".format(inc) req_url = "/requests/new/{}".format(inc)
if req: if req:
req_url += "/" + req req_url += "/" + req
# we do it twice, with and without redirect, in order to get the # we do it twice, with and without redirect, in order to get the
# destination url # destination url
prelim_resp = post_form(req_url) prelim_resp = post_form(req_url, data=data)
response = post_form(req_url, True) response = post_form(req_url, True, data=data)
return (prelim_resp.headers.get("Location"), response) return (prelim_resp.headers.get("Location"), response)
# GET the initial form # GET the initial form
@ -41,9 +42,26 @@ def test_stepthrough_request_form(monkeypatch, user_session, screens, client):
# POST to each of the form pages up until review and submit # POST to each of the form pages up until review and submit
req_id = None req_id = None
for i in range(1, len(screens)): for i in range(1, len(screens)):
effective_url, resp = take_a_step(i, req=req_id) # get appropriate form data to POST for this section
section = screens[i - 1]["section"]
post_data = urlencode(mock_request.body[section])
effective_url, resp = take_a_step(i, req=req_id, data=post_data)
req_id = effective_url.split("/")[-1] req_id = effective_url.split("/")[-1]
screen_title = screens[i]["title"].replace("&", "&") screen_title = screens[i]["title"].replace("&", "&")
assert "/requests/new/{}/{}".format(i + 1, req_id) in effective_url assert "/requests/new/{}/{}".format(i + 1, req_id) in effective_url
assert screen_title in resp.data.decode() assert screen_title in resp.data.decode()
# at this point, the real request we made and the mock_request bodies
# should be equivalent
assert Requests.get(req_id).body == mock_request.body
# finish the review and submit step
client.post(
"/requests/submit/{}".format(req_id),
headers={"Content-Type": "application/x-www-form-urlencoded"},
)
finished_request = Requests.get(req_id)
assert finished_request.status == RequestStatus.PENDING_CCPO_APPROVAL