From 7e4723452cb9359b82f8124628756eeb33c99c4a Mon Sep 17 00:00:00 2001
From: dandds <dan-ctr@friends.dds.mil>
Date: Mon, 13 Aug 2018 10:58:05 -0400
Subject: [PATCH] improve integration test: no monkeypatching, assert request
 is submitted

---
 tests/test_integration.py | 48 +++++++++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 15 deletions(-)

diff --git a/tests/test_integration.py b/tests/test_integration.py
index 4788e4c4..633f14b1 100644
--- a/tests/test_integration.py
+++ b/tests/test_integration.py
@@ -1,37 +1,38 @@
 import pytest
-from .factories import UserFactory
+from urllib.parse import urlencode
+from .factories import UserFactory, RequestFactory
+
 from atst.routes.requests.jedi_request_flow import JEDIRequestFlow
+from atst.models.request_status_event import RequestStatus
+from atst.domain.requests import Requests
+
 
 @pytest.fixture
 def screens(app):
     return JEDIRequestFlow(3).screens
 
 
-def test_stepthrough_request_form(monkeypatch, user_session, screens, client):
+def test_stepthrough_request_form(user_session, screens, client):
     user = UserFactory.create()
     user_session(user)
+    mock_request = RequestFactory.stub()
 
-    monkeypatch.setattr(
-        "atst.routes.requests.jedi_request_flow.JEDIRequestFlow.validate", lambda s: True
-    )
-
-    def post_form(url, redirects=False):
-         return client.post(
+    def post_form(url, redirects=False, data=""):
+        return client.post(
             url,
             headers={"Content-Type": "application/x-www-form-urlencoded"},
-            data="meaning=42",
-            follow_redirects=redirects
+            data=data,
+            follow_redirects=redirects,
         )
 
-
-    def take_a_step(inc, req=None):
+    def take_a_step(inc, req=None, data=None):
         req_url = "/requests/new/{}".format(inc)
         if req:
             req_url += "/" + req
         # we do it twice, with and without redirect, in order to get the
         # destination url
-        prelim_resp = post_form(req_url)
-        response = post_form(req_url, True)
+        prelim_resp = post_form(req_url, data=data)
+        response = post_form(req_url, True, data=data)
         return (prelim_resp.headers.get("Location"), response)
 
     # GET the initial form
@@ -41,9 +42,26 @@ def test_stepthrough_request_form(monkeypatch, user_session, screens, client):
     # POST to each of the form pages up until review and submit
     req_id = None
     for i in range(1, len(screens)):
-        effective_url, resp = take_a_step(i, req=req_id)
+        # get appropriate form data to POST for this section
+        section = screens[i - 1]["section"]
+        post_data = urlencode(mock_request.body[section])
+
+        effective_url, resp = take_a_step(i, req=req_id, data=post_data)
         req_id = effective_url.split("/")[-1]
         screen_title = screens[i]["title"].replace("&", "&amp;")
 
         assert "/requests/new/{}/{}".format(i + 1, req_id) in effective_url
         assert screen_title in resp.data.decode()
+
+    # at this point, the real request we made and the mock_request bodies
+    # should be equivalent
+    assert Requests.get(req_id).body == mock_request.body
+
+    # finish the review and submit step
+    client.post(
+        "/requests/submit/{}".format(req_id),
+        headers={"Content-Type": "application/x-www-form-urlencoded"},
+    )
+
+    finished_request = Requests.get(req_id)
+    assert finished_request.status == RequestStatus.PENDING_CCPO_APPROVAL