pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #215 from dod-ccpo/task-order-invalid

Browse Source 
record invalid task order number on the request body
This commit is contained in:
dandds 2018-08-27 11:29:45 -04:00 committed by GitHub
commit 700d914a55
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
atst/domain/requests.py
View File

@ -244,7 +244,10 @@ WHERE requests_with_status.status = :status
for (k, v) in financial_data.items() for (k, v) in financial_data.items()
if k in TaskOrders.TASK_ORDER_DATA if k in TaskOrders.TASK_ORDER_DATA
} }
task_order_number = request_data.pop("task_order_number") if task_order_data:
task_order_number = request_data.pop("task_order_number")
else:
task_order_number = request_data.get("task_order_number")
task_order = TaskOrders.get_or_create_task_order( task_order = TaskOrders.get_or_create_task_order(
task_order_number, task_order_data task_order_number, task_order_data

5
tests/domain/test_requests.py
View File

@ -154,3 +154,8 @@ def test_update_financial_verification_with_invalid_task_order():
request = RequestFactory.create() request = RequestFactory.create()
Requests.update_financial_verification(request.id, request_financial_data) Requests.update_financial_verification(request.id, request_financial_data)
assert not request.task_order assert not request.task_order
assert "task_order_number" in request.body.get("financial_verification")
assert (
request.body["financial_verification"]["task_order_number"]
== request_financial_data["task_order_number"]
)