From 43f1866783e0a56676c5afaf79e0c2bace2c2bf6 Mon Sep 17 00:00:00 2001 From: dandds Date: Mon, 27 Aug 2018 09:14:28 -0400 Subject: [PATCH] record invalid task order number on the request body --- atst/domain/requests.py | 5 ++++- tests/domain/test_requests.py | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/atst/domain/requests.py b/atst/domain/requests.py index 4d6473a5..4b18595f 100644 --- a/atst/domain/requests.py +++ b/atst/domain/requests.py @@ -244,7 +244,10 @@ WHERE requests_with_status.status = :status for (k, v) in financial_data.items() if k in TaskOrders.TASK_ORDER_DATA } - task_order_number = request_data.pop("task_order_number") + if task_order_data: + task_order_number = request_data.pop("task_order_number") + else: + task_order_number = request_data.get("task_order_number") task_order = TaskOrders.get_or_create_task_order( task_order_number, task_order_data diff --git a/tests/domain/test_requests.py b/tests/domain/test_requests.py index 3add8ae9..582bb02f 100644 --- a/tests/domain/test_requests.py +++ b/tests/domain/test_requests.py @@ -154,3 +154,8 @@ def test_update_financial_verification_with_invalid_task_order(): request = RequestFactory.create() Requests.update_financial_verification(request.id, request_financial_data) assert not request.task_order + assert "task_order_number" in request.body.get("financial_verification") + assert ( + request.body["financial_verification"]["task_order_number"] + == request_financial_data["task_order_number"] + )