pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix issue with db.session.commit history and disabling portfolio role

Browse Source
This commit is contained in:
George Drummond 2019-06-07 10:53:34 -04:00
parent cad43af455
commit 5bcfcc1568
No known key found for this signature in database
GPG Key ID: 296DD6077123BF17
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
atst/domain/portfolio_roles.py
View File

@ -144,10 +144,12 @@ class PortfolioRoles(object):
PortfolioRoles.update(portfolio_role=portfolio_role, set_names=permission_sets)
@classmethod
def disable(cls, portfolio_role):
def disable(cls, portfolio_role, commit=True):
portfolio_role.status = PortfolioRoleStatus.DISABLED
db.session.add(portfolio_role)
if commit:
db.session.commit()
return portfolio_role

2
atst/domain/portfolios/portfolios.py
View File

@ -43,7 +43,7 @@ class Portfolios(object):
raise PortfolioDeletionApplicationsExistError()
for portfolio_role in portfolio.roles:
PortfolioRoles.disable(portfolio_role)
PortfolioRoles.disable(portfolio_role=portfolio_role, commit=False)
portfolio.deleted = True