diff --git a/atst/domain/portfolio_roles.py b/atst/domain/portfolio_roles.py index d20625c2..9691f242 100644 --- a/atst/domain/portfolio_roles.py +++ b/atst/domain/portfolio_roles.py @@ -144,11 +144,13 @@ class PortfolioRoles(object): PortfolioRoles.update(portfolio_role=portfolio_role, set_names=permission_sets) @classmethod - def disable(cls, portfolio_role): + def disable(cls, portfolio_role, commit=True): portfolio_role.status = PortfolioRoleStatus.DISABLED db.session.add(portfolio_role) - db.session.commit() + + if commit: + db.session.commit() return portfolio_role diff --git a/atst/domain/portfolios/portfolios.py b/atst/domain/portfolios/portfolios.py index 5fcd5320..25da6249 100644 --- a/atst/domain/portfolios/portfolios.py +++ b/atst/domain/portfolios/portfolios.py @@ -43,7 +43,7 @@ class Portfolios(object): raise PortfolioDeletionApplicationsExistError() for portfolio_role in portfolio.roles: - PortfolioRoles.disable(portfolio_role) + PortfolioRoles.disable(portfolio_role=portfolio_role, commit=False) portfolio.deleted = True