Fix issue with db.session.commit history and disabling portfolio role

2019-06-07 10:53:34 -04:00
parent cad43af455
commit 5bcfcc1568
2 changed files with 5 additions and 3 deletions
--- a/atst/domain/portfolio_roles.py
+++ b/atst/domain/portfolio_roles.py
@@ -144,11 +144,13 @@ class PortfolioRoles(object):
        PortfolioRoles.update(portfolio_role=portfolio_role, set_names=permission_sets)

    @classmethod
-    def disable(cls, portfolio_role):
+    def disable(cls, portfolio_role, commit=True):
        portfolio_role.status = PortfolioRoleStatus.DISABLED

        db.session.add(portfolio_role)
-        db.session.commit()
+
+        if commit:
+            db.session.commit()

        return portfolio_role