remove REQUIRE_CRLS setting in favor of DISABLE_CRL_CHECK

atst/app.py

@@ -48,10 +48,7 @@ def make_app(config):
     app.config.update({"SESSION_REDIS": app.redis})
 
     make_flask_callbacks(app)
-    # TODO: deprecate the REQUIRE_CRLs setting in favor of the
-    # DISABLE_CRL_CHECK; both have the effect of never loading CRLs
-    if app.config.get("REQUIRE_CRLS"):
-        make_crl_validator(app)
+    make_crl_validator(app)
     register_filters(app)
     make_eda_client(app)
     make_csp_provider(app)
@@ -132,7 +129,6 @@ def map_config(config):
         "PERMANENT_SESSION_LIFETIME": config.getint(
             "default", "PERMANENT_SESSION_LIFETIME"
         ),
-        "REQUIRE_CRLS": config.getboolean("default", "REQUIRE_CRLS"),
         "RQ_REDIS_URL": config["default"]["REDIS_URI"],
         "RQ_QUEUES": [config["default"]["RQ_QUEUES"]],
         "DISABLE_CRL_CHECK": config.getboolean("default", "DISABLE_CRL_CHECK"),

config/base.ini

@@ -17,7 +17,6 @@ PGPORT = 5432
 PGUSER = postgres
 PORT=8000
 REDIS_URI = redis://localhost:6379
-REQUIRE_CRLS = true
 RQ_QUEUES = atat_%(ENVIRONMENT)s
 SECRET = change_me_into_something_secret
 SECRET_KEY = change_me_into_something_secret

deploy/kubernetes/atst-worker-envvars-configmap.yml

@@ -5,4 +5,4 @@ metadata:
   name: atst-worker-envvars
   namespace: atat
 data:
-  REQUIRE_CRLS: "False"
+  DISABLE_CRL_CHECK: "True"

deploy/kubernetes/test/atst-worker-envvars-configmap.yml

@@ -5,4 +5,4 @@ metadata:
   name: atst-worker-envvars
   namespace: atat-test
 data:
-  REQUIRE_CRLS: "False"
+  DISABLE_CRL_CHECK: "True"

deploy/kubernetes/uat/atst-worker-envvars-configmap.yml

@@ -5,4 +5,4 @@ metadata:
   name: atst-worker-envvars
   namespace: atat-uat
 data:
-  REQUIRE_CRLS: "False"
+  DISABLE_CRL_CHECK: "True"