pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix flashed message after creating portfolio member

Browse Source
This commit is contained in:
Patrick Smith 2019-02-10 14:36:33 -05:00
parent 20d1ffecd9
commit 425fba99da
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
atst/routes/portfolios/members.py
View File

@ -26,10 +26,6 @@ from atst.utils.flash import formatted_flash as flash
@portfolios_bp.route("/portfolios/<portfolio_id>/members") @portfolios_bp.route("/portfolios/<portfolio_id>/members")
def portfolio_members(portfolio_id): def portfolio_members(portfolio_id):
portfolio = Portfolios.get_with_members(g.current_user, portfolio_id) portfolio = Portfolios.get_with_members(g.current_user, portfolio_id)
new_member_name = http_request.args.get("newMemberName")
new_member = next(
filter(lambda m: m.user_name == new_member_name, portfolio.members), None
)
members_list = [ members_list = [
{ {
"name": k.user_name, "name": k.user_name,
@ -50,7 +46,6 @@ def portfolio_members(portfolio_id):
role_choices=PORTFOLIO_ROLE_DEFINITIONS, role_choices=PORTFOLIO_ROLE_DEFINITIONS,
status_choices=MEMBER_STATUS_CHOICES, status_choices=MEMBER_STATUS_CHOICES,
members=members_list, members=members_list,
new_member=new_member,
) )
@ -76,7 +71,7 @@ def create_member(portfolio_id):
) )
invite_service.invite() invite_service.invite()
flash("new_portfolio_member", new_member=new_member, portfolio=portfolio) flash("new_portfolio_member", new_member=member, portfolio=portfolio)
return redirect( return redirect(
url_for("portfolios.portfolio_members", portfolio_id=portfolio.id) url_for("portfolios.portfolio_members", portfolio_id=portfolio.id)

1
tests/routes/portfolios/test_members.py
View File

@ -92,6 +92,7 @@ def test_create_member(client, user_session):
) )
assert response.status_code == 200 assert response.status_code == 200
assert user.full_name in response.data.decode()
assert user.has_portfolios assert user.has_portfolios
assert user.invitations assert user.invitations
assert len(queue.get_queue()) == queue_length + 1 assert len(queue.get_queue()) == queue_length + 1