From 425fba99da583568628a09b733d92638a6a53aa1 Mon Sep 17 00:00:00 2001 From: Patrick Smith Date: Sun, 10 Feb 2019 14:36:33 -0500 Subject: [PATCH] Fix flashed message after creating portfolio member --- atst/routes/portfolios/members.py | 7 +------ tests/routes/portfolios/test_members.py | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/atst/routes/portfolios/members.py b/atst/routes/portfolios/members.py index e549cdf2..182fe74f 100644 --- a/atst/routes/portfolios/members.py +++ b/atst/routes/portfolios/members.py @@ -26,10 +26,6 @@ from atst.utils.flash import formatted_flash as flash @portfolios_bp.route("/portfolios//members") def portfolio_members(portfolio_id): portfolio = Portfolios.get_with_members(g.current_user, portfolio_id) - new_member_name = http_request.args.get("newMemberName") - new_member = next( - filter(lambda m: m.user_name == new_member_name, portfolio.members), None - ) members_list = [ { "name": k.user_name, @@ -50,7 +46,6 @@ def portfolio_members(portfolio_id): role_choices=PORTFOLIO_ROLE_DEFINITIONS, status_choices=MEMBER_STATUS_CHOICES, members=members_list, - new_member=new_member, ) @@ -76,7 +71,7 @@ def create_member(portfolio_id): ) invite_service.invite() - flash("new_portfolio_member", new_member=new_member, portfolio=portfolio) + flash("new_portfolio_member", new_member=member, portfolio=portfolio) return redirect( url_for("portfolios.portfolio_members", portfolio_id=portfolio.id) diff --git a/tests/routes/portfolios/test_members.py b/tests/routes/portfolios/test_members.py index c8d97b61..58078f35 100644 --- a/tests/routes/portfolios/test_members.py +++ b/tests/routes/portfolios/test_members.py @@ -92,6 +92,7 @@ def test_create_member(client, user_session): ) assert response.status_code == 200 + assert user.full_name in response.data.decode() assert user.has_portfolios assert user.invitations assert len(queue.get_queue()) == queue_length + 1