Updates from PR feedback

This commit is contained in:
leigh-mil 2019-04-03 12:23:42 -04:00
parent 2feb10ea98
commit 215c2b4cbc
3 changed files with 3 additions and 7 deletions

View File

@ -85,7 +85,7 @@ class Users(object):
@classmethod
def update_last_login(cls, user):
setattr(user, "last_login", datetime.now())
user.last_login = datetime.now()
db.session.add(user)
db.session.commit()

View File

@ -9,7 +9,7 @@
</div>
{% if g.last_login %}
<div class="">
Last Login: <local-datetime timestamp='{{ g.last_login }}' format='MMM D YYYY H:mm Z'></local-datetime>
Last Login: <local-datetime timestamp='{{ g.last_login }}'></local-datetime>
</div>
{% endif %}
</footer>

View File

@ -69,12 +69,8 @@ def test_update_user_with_dod_id():
def test_update_user_with_last_login():
new_user = UserFactory.create(last_login=datetime.now())
new_user = UserFactory.create()
Users.update_last_login(new_user)
last_login = new_user.last_login
with pytest.raises(UnauthorizedError):
Users.update(new_user, {"last_login": datetime.now()})
Users.update_last_login(new_user)
assert new_user.last_login > last_login