Fix python anti patterns

This commit is contained in:
George Drummond 2019-01-02 09:36:09 -05:00
parent 5198fd8889
commit 1941b57995
No known key found for this signature in database
GPG Key ID: 296DD6077123BF17

View File

@ -25,11 +25,14 @@ def load_cached_translations_file(file_name):
return open(file_name).read() return open(file_name).read()
def translate(key, variables={}): def translate(key, variables=None):
translations = yaml.safe_load(load_cached_translations_file("translations.yaml")) translations = yaml.safe_load(load_cached_translations_file("translations.yaml"))
value = getattr_path(translations, key) value = getattr_path(translations, key)
if value == None: if variables is None:
variables = {}
if value is None:
raise LocalizationInvalidKeyError(key, variables) raise LocalizationInvalidKeyError(key, variables)
return value.format(**variables).replace("\n", "") return value.format(**variables).replace("\n", "")