From 1941b5799572585b1551391ca1134571bcf5d75e Mon Sep 17 00:00:00 2001 From: George Drummond Date: Wed, 2 Jan 2019 09:36:09 -0500 Subject: [PATCH] Fix python anti patterns --- atst/utils/localization.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/atst/utils/localization.py b/atst/utils/localization.py index eff45b6a..2a5d69ac 100644 --- a/atst/utils/localization.py +++ b/atst/utils/localization.py @@ -25,11 +25,14 @@ def load_cached_translations_file(file_name): return open(file_name).read() -def translate(key, variables={}): +def translate(key, variables=None): translations = yaml.safe_load(load_cached_translations_file("translations.yaml")) value = getattr_path(translations, key) - if value == None: + if variables is None: + variables = {} + + if value is None: raise LocalizationInvalidKeyError(key, variables) return value.format(**variables).replace("\n", "")