pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not create AuditEvent if updating the User.last_login

Browse Source
This commit is contained in:
leigh-mil 2019-08-16 16:41:58 -04:00
parent 4a54602cc6
commit 0d6f7aa3cc
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
atst/models/mixins/auditable.py
View File

@ -54,7 +54,8 @@ class AuditableMixin(object):
@staticmethod
def audit_update(mapper, connection, target):
if AuditableMixin.get_changes(target):
changes = AuditableMixin.get_changes(target)
if changes and not "last_login" in changes:
target.create_audit_event(connection, target, ACTION_UPDATE)
def get_changes(self):

6
tests/models/mixins/test_auditable.py
View File

@ -51,3 +51,9 @@ def test_logging_audit_event_on_update(mock_logger):
assert event_log["action"] == "update"
assert "update" in mock_logger.extras[1]["tags"]
def test_does_not_log_user_update_when_updating_last_login(mock_logger):
user = UserFactory.create()
Users.update_last_login(user)
assert "Audit Event update" not in mock_logger.messages