In the future, an `application_invitation1 will not refer to a `user` until someone accepts the invitation; they'll only reference an `application_role`. When a user is invited to an application, the inviter can specify the environments the invitee should have access to. For this to be possible, an `environment_role` should reference an `application_role`, because no `user` entity will be known at that time. In addition to updating all the models and domain methods necessary for this change, this commit deletes unused code and tests that were dependent on `environment_roles` having a `user_id` foreign key.
192 lines
5.8 KiB
Python
192 lines
5.8 KiB
Python
import pytest
|
|
from uuid import uuid4
|
|
|
|
from atst.models import CSPRole, ApplicationRoleStatus
|
|
from atst.domain.application_roles import ApplicationRoles
|
|
from atst.domain.applications import Applications
|
|
from atst.domain.environment_roles import EnvironmentRoles
|
|
from atst.domain.exceptions import NotFoundError
|
|
from atst.domain.permission_sets import PermissionSets
|
|
|
|
from tests.factories import (
|
|
ApplicationFactory,
|
|
ApplicationRoleFactory,
|
|
EnvironmentFactory,
|
|
EnvironmentRoleFactory,
|
|
PortfolioFactory,
|
|
UserFactory,
|
|
)
|
|
|
|
|
|
def test_create_application_with_multiple_environments():
|
|
portfolio = PortfolioFactory.create()
|
|
application = Applications.create(
|
|
portfolio, "My Test Application", "Test", ["dev", "prod"]
|
|
)
|
|
|
|
assert application.portfolio == portfolio
|
|
assert application.name == "My Test Application"
|
|
assert application.description == "Test"
|
|
assert sorted(e.name for e in application.environments) == ["dev", "prod"]
|
|
|
|
|
|
def test_portfolio_owner_can_view_environments():
|
|
owner = UserFactory.create()
|
|
portfolio = PortfolioFactory.create(
|
|
owner=owner,
|
|
applications=[{"environments": [{"name": "dev"}, {"name": "prod"}]}],
|
|
)
|
|
application = Applications.get(portfolio.applications[0].id)
|
|
|
|
assert len(application.environments) == 2
|
|
|
|
|
|
def test_can_only_update_name_and_description():
|
|
owner = UserFactory.create()
|
|
portfolio = PortfolioFactory.create(
|
|
owner=owner,
|
|
applications=[
|
|
{
|
|
"name": "Application 1",
|
|
"description": "a application",
|
|
"environments": [{"name": "dev"}],
|
|
}
|
|
],
|
|
)
|
|
application = Applications.get(portfolio.applications[0].id)
|
|
env_name = application.environments[0].name
|
|
Applications.update(
|
|
application,
|
|
{
|
|
"name": "New Name",
|
|
"description": "a new application",
|
|
"environment_name": "prod",
|
|
},
|
|
)
|
|
|
|
assert application.name == "New Name"
|
|
assert application.description == "a new application"
|
|
assert len(application.environments) == 1
|
|
assert application.environments[0].name == env_name
|
|
|
|
|
|
def test_get_excludes_deleted():
|
|
app = ApplicationFactory.create(deleted=True)
|
|
with pytest.raises(NotFoundError):
|
|
Applications.get(app.id)
|
|
|
|
|
|
def test_get_application():
|
|
app = ApplicationFactory.create()
|
|
assert Applications.get(app.id) == app
|
|
assert Applications.get(app.id, portfolio_id=app.portfolio_id) == app
|
|
with pytest.raises(NotFoundError):
|
|
# make the uuid a string like you'd get from a route
|
|
rando_id = str(uuid4())
|
|
Applications.get(app.id, portfolio_id=rando_id)
|
|
|
|
|
|
def test_delete_application(session):
|
|
app = ApplicationFactory.create()
|
|
app_role = ApplicationRoleFactory.create(user=UserFactory.create(), application=app)
|
|
env1 = EnvironmentFactory.create(application=app)
|
|
env2 = EnvironmentFactory.create(application=app)
|
|
assert not app.deleted
|
|
assert not env1.deleted
|
|
assert not env2.deleted
|
|
assert not app_role.deleted
|
|
|
|
Applications.delete(app)
|
|
|
|
assert app.deleted
|
|
assert env1.deleted
|
|
assert env2.deleted
|
|
assert app_role.deleted
|
|
|
|
# changes are flushed
|
|
assert not session.dirty
|
|
|
|
|
|
def test_create_member():
|
|
application = ApplicationFactory.create()
|
|
env1 = EnvironmentFactory.create(application=application)
|
|
env2 = EnvironmentFactory.create(application=application)
|
|
user_data = UserFactory.dictionary()
|
|
permission_set_names = [PermissionSets.EDIT_APPLICATION_TEAM]
|
|
|
|
member_role = Applications.create_member(
|
|
application,
|
|
user_data,
|
|
permission_set_names,
|
|
environment_roles_data=[
|
|
{"environment_id": env1.id, "role": CSPRole.BASIC_ACCESS.value},
|
|
{"environment_id": env2.id, "role": None},
|
|
],
|
|
)
|
|
|
|
assert member_role.user.dod_id == user_data["dod_id"]
|
|
# view application AND edit application team
|
|
assert len(member_role.permission_sets) == 2
|
|
|
|
env_roles = member_role.environment_roles
|
|
assert len(env_roles) == 1
|
|
assert env_roles[0].environment == env1
|
|
|
|
|
|
def test_for_user():
|
|
user = UserFactory.create()
|
|
portfolio = PortfolioFactory.create()
|
|
for _x in range(4):
|
|
ApplicationFactory.create(portfolio=portfolio)
|
|
|
|
ApplicationRoleFactory.create(
|
|
application=portfolio.applications[0],
|
|
user=user,
|
|
status=ApplicationRoleStatus.ACTIVE,
|
|
)
|
|
ApplicationRoleFactory.create(
|
|
application=portfolio.applications[1],
|
|
user=user,
|
|
status=ApplicationRoleStatus.ACTIVE,
|
|
)
|
|
ApplicationRoleFactory.create(
|
|
application=portfolio.applications[2],
|
|
user=user,
|
|
status=ApplicationRoleStatus.PENDING,
|
|
)
|
|
|
|
assert len(portfolio.applications) == 4
|
|
user_applications = Applications.for_user(user, portfolio)
|
|
assert len(user_applications) == 2
|
|
|
|
|
|
def test_remove_member():
|
|
application = ApplicationFactory.create()
|
|
user = UserFactory.create()
|
|
member_role = ApplicationRoleFactory.create(application=application, user=user)
|
|
environment = EnvironmentFactory.create(application=application)
|
|
environment_role = EnvironmentRoleFactory.create(
|
|
application_role=member_role, environment=environment
|
|
)
|
|
|
|
assert member_role == ApplicationRoles.get(
|
|
user_id=user.id, application_id=application.id
|
|
)
|
|
|
|
Applications.remove_member(application=application, user_id=member_role.user.id)
|
|
|
|
assert (
|
|
ApplicationRoles.get(user_id=user.id, application_id=application.id).status
|
|
== ApplicationRoleStatus.DISABLED
|
|
)
|
|
|
|
#
|
|
# TODO: Why does above raise NotFoundError and this returns None
|
|
#
|
|
assert (
|
|
EnvironmentRoles.get(
|
|
application_role_id=member_role.id, environment_id=environment.id
|
|
)
|
|
is None
|
|
)
|