Commit Graph

2046 Commits

Author SHA1 Message Date
dandds
129f5e3031 Rewrite function that builds form data for app environment roles form.
- Adds a property to ApplicationRole model so that it knows its related
  EnvironmentRole models.
- Rewrite the form data builder in the routes file so that it loops the
  application members and their environment roles to build the data
  structure.
2019-05-24 13:34:53 -04:00
dandds
7f745302ec Merge pull request #843 from dod-ccpo/app-team-role-id
Use application_role.id to reference users in team page forms.
2019-05-23 11:14:33 -04:00
dandds
a332d1432e Use application_role.id to reference users in team page forms.
Membership in a resource should be decoupled from the users table.
2019-05-23 10:13:57 -04:00
dandds
4c4796ecc3 Merge pull request #841 from dod-ccpo/ppoc-role-id
Use portfolio_role.id for updating primary point of contact.
2019-05-23 10:11:33 -04:00
dandds
e3ace36466 Use portfolio_role.id for updating primary point of contact.
Our forms should rely on role IDs for displaying user information on the
portfolio page. This way they are decoupled from user table data and can
eventually rely on invitation user data where an invitation has been
sent but a user does not exist yet.
2019-05-22 15:59:04 -04:00
George Drummond
da6ac57812 Merge pull request #836 from dod-ccpo/sidebar
Applications users were invited to were not showing in the portfolios sidebar
2019-05-22 15:22:05 -04:00
George Drummond
41e2d14e7d Use sqlalchemy or_ 2019-05-22 15:17:31 -04:00
leigh-mil
4df975acf9 Merge pull request #832 from dod-ccpo/add-app-audit-log
Add app audit log
2019-05-22 15:07:47 -04:00
montana-mil
2de4d1477a Merge pull request #837 from dod-ccpo/default-env-roles-for-app-users
Use No Access as default role value for app users
2019-05-22 15:07:27 -04:00
George Drummond
bb4b52c6ac Add in missing route 2019-05-22 13:46:49 -04:00
George Drummond
b61f304bad Make one query 2019-05-22 13:32:13 -04:00
George Drummond
9098bc7c0b Reduce number of queries performed during the lookup 2019-05-22 13:24:57 -04:00
leigh-mil
7756ab8c28 Notes about unused methods that need more research 2019-05-22 13:12:48 -04:00
leigh-mil
9f66bbafe5 Raise NotImplementedError in AuditableMixin if the model does not have the properties portfolio_id or application_id 2019-05-22 13:12:48 -04:00
leigh-mil
5e2f00b1c2 Add perms for viewing application log 2019-05-22 13:12:48 -04:00
leigh-mil
a65f758894 Add templates to display new audit events 2019-05-22 13:08:44 -04:00
leigh-mil
a1eb7ec935 Make sure all log events have portfolio and app ids (where applicable) 2019-05-22 13:08:44 -04:00
leigh-mil
927d1b7925 Add audit log to app settings page 2019-05-22 13:08:44 -04:00
leigh-mil
b3ecd1658c Add application_id column to AuditEvent
Use application_id and portfolio_id if the resource is a portfolio in AuditableMixin
Clean up some residual references to workspace
2019-05-22 13:08:44 -04:00
George Drummond
6487fe91ba Applications users were invited to were not showing in the portfolios
sidebar
2019-05-22 11:19:13 -04:00
George Drummond
1bf5075b80 Record the email subject for notification logs 2019-05-22 10:20:18 -04:00
dandds
8add5b4e22 Filter deleted environment roles from top-level domain method. 2019-05-21 14:08:14 -04:00
Montana
c329e5ffcf Use No Access as default role value for app users
-adds unit tests for EnvironmentForm
-removes unused import from forms/team.py
2019-05-21 10:37:03 -04:00
richard-dds
32df561c6d Merge pull request #827 from dod-ccpo/stig-notifications
Create Notification System
2019-05-20 09:51:09 -04:00
dandds
0cdba66b0c Merge pull request #829 from dod-ccpo/portfolio-role-display
Use portfolio_role entity to display and update portfolio member info.
2019-05-20 09:37:55 -04:00
dandds
01a935f257 Merge pull request #822 from dod-ccpo/app-members-edit
App members edit
2019-05-17 14:08:06 -04:00
dandds
815632ed00 Handle setting no access for user environment roles:
- use constant for no access string
- update no access constant
- update language and permissions for rendering remove app member button
2019-05-17 14:00:45 -04:00
dandds
0dc0397702 Update user's environment role on the team page.
- Includes adjustments to the applications.update_team route
- Adds hidden environment ID to the HTML form
2019-05-17 14:00:45 -04:00
dandds
d38c4df878 Form components for changing user environment role 2019-05-17 14:00:44 -04:00
George Drummond
15d4b48184 Looking up g.portfolio when g.current_user is None raises an error 2019-05-17 13:29:40 -04:00
dandds
291cc6b3b3 Merge pull request #826 from dod-ccpo/crl-silent-fail
Raise error if CRL download fails.
2019-05-16 12:52:26 -04:00
dandds
c8682c0897 Use portfolio_role entity to display and update portfolio member info.
Previously, we were encoding the portfolio_role.user_id as part of the
form data for the portfolio admin page. This was convenient because it
allowed us to easily determine certain display attributes in the
template. Instead, we should rely on the PortfolioRole as the source of
truth for member information. This commit adds:

- Portfolio.owner_role to return the PortfolioRole of the owner
- explicitly passes the PortfolioRole IDs for the PPoC and current user
  to the template
- PortfolioRole.full_name for deriving the member name
2019-05-16 08:04:48 -04:00
richard-dds
fe5def3a92 Send notification emails on some http errors 2019-05-15 15:01:49 -04:00
richard-dds
d8e75668b0 Log notifications at the time of sending 2019-05-15 14:57:46 -04:00
richard-dds
9ba1def91c Use separate queue method for notifications 2019-05-15 14:57:46 -04:00
richard-dds
97b9d84c38 Select only recipient emails from the db 2019-05-15 14:57:46 -04:00
richard-dds
d3b42d5bfc Formatting 2019-05-15 14:57:46 -04:00
richard-dds
df7f72245a Send notification when we encounter an error 2019-05-15 14:57:46 -04:00
richard-dds
c03b69b351 More idiomatic initialization of notification_sender 2019-05-15 14:57:46 -04:00
richard-dds
aaa9d47ccf Wire up NotificationSender to the app's error handler 2019-05-15 14:57:46 -04:00
richard-dds
a6c5f484b9 Add NotificationSender, one test 2019-05-15 14:57:46 -04:00
dandds
f7c3fe572b Raise error if CRL download fails.
The download method for Libcloud objects returns a boolean, which means
that our CRL download could fail silently. The RackspaceCRLProvider
would not raise an error until it tried to open the full path for the
downloaded resource. This checks the return status of the download call
and raises an error if the download failed. For reference:

https://libcloud.readthedocs.io/en/latest/storage/api.html#libcloud.storage.base.StorageDriver.download_object
2019-05-15 14:38:33 -04:00
rachel-dtr
c6790e5d7a Updating alert language 2019-05-15 13:28:46 -04:00
montana-mil
a3c808a09f Merge pull request #819 from dod-ccpo/handle-none-checkbox-value
Catch None values for IsNumber validator
2019-05-15 11:58:22 -04:00
Montana
86c6044ca1 Catch None values for IsNumber validator 2019-05-15 11:41:03 -04:00
montana-mil
1c4725840c Merge pull request #815 from dod-ccpo/add-new-env-app-settings
Add New Environment via app settings
2019-05-15 11:30:29 -04:00
George Drummond
b8ea1349b2 Merge pull request #817 from dod-ccpo/delete-user-from-application
Delete an application member
2019-05-14 15:45:32 -04:00
George Drummond
9927b22783 Disable rather than delete application_roles 2019-05-14 15:26:51 -04:00
Montana
1c506b995a Use helper function to render settings page
- use front end for validation testing
- change "form" to "application_form"
2019-05-14 15:16:53 -04:00
George Drummond
f1299dc4b0 Add DELETE_APPLICATION_MEMBER permission 2019-05-14 13:39:20 -04:00