Send notification emails on some http errors

tests/conftest.py

@@ -309,7 +309,7 @@ def mock_logger(app):
     app.logger = real_logger
 
 
-@pytest.fixture(scope="session", autouse=True)
+@pytest.fixture(scope="function", autouse=True)
 def notification_sender(app):
     real_notification_sender = app.notification_sender
     app.notification_sender = FakeNotificationSender()

tests/routes/test_errors.py

@@ -1,5 +1,7 @@
 import pytest
 from flask import url_for
+from copy import copy
+from tests.factories import UserFactory
 
 
 @pytest.fixture
@@ -20,3 +22,16 @@ def test_csrf_error(csrf_enabled_app, client):
     body = response.data.decode()
     assert "Session Expired" in body
     assert "Log in required" in body
+
+
+def test_errors_generate_notifications(app, client, user_session, notification_sender):
+    user_session(UserFactory.create())
+    new_app = copy(app)
+
+    @new_app.route("/throw")
+    def throw():
+        raise ValueError()
+
+    new_app.test_client().get("/throw")
+
+    notification_sender.send.assert_called_once()

tests/utils.py

@@ -42,4 +42,4 @@ class FakeLogger:
             self.extras.append(kwargs["extra"])
 
 
-FakeNotificationSender = Mock(spec=NotificationSender)
+FakeNotificationSender = lambda: Mock(spec=NotificationSender)