Change Environment.creator relation from ApplicationRole to User

tests/domain/test_applications.py

@@ -21,7 +21,7 @@ from tests.factories import (
 def test_create_application_with_multiple_environments():
     portfolio = PortfolioFactory.create()
     application = Applications.create(
-        portfolio, "My Test Application", "Test", ["dev", "prod"]
+        portfolio.owner, portfolio, "My Test Application", "Test", ["dev", "prod"]
     )
 
     assert application.portfolio == portfolio

tests/domain/test_environments.py

@@ -21,7 +21,9 @@ from tests.factories import (
 @pytest.mark.skip(reason="Reinstate and update once jobs api is up")
 def test_create_environments():
     application = ApplicationFactory.create()
-    environments = Environments.create_many(application, ["Staging", "Production"])
+    environments = Environments.create_many(
+        application.portfolio.owner, application, ["Staging", "Production"]
+    )
     for env in environments:
         assert env.cloud_id is not None
 

tests/domain/test_portfolios.py

@@ -71,7 +71,11 @@ def test_update_portfolio_role_role(portfolio, portfolio_owner):
 
 def test_scoped_portfolio_for_admin_missing_view_apps_perms(portfolio_owner, portfolio):
     Applications.create(
-        portfolio, "My Application 2", "My application 2", ["dev", "staging", "prod"]
+        portfolio.owner,
+        portfolio,
+        "My Application 2",
+        "My application 2",
+        ["dev", "staging", "prod"],
     )
     restricted_admin = UserFactory.create()
     PortfolioRoleFactory.create(
@@ -90,7 +94,11 @@ def test_scoped_portfolio_returns_all_applications_for_portfolio_admin(
 ):
     for _ in range(5):
         Applications.create(
-            portfolio, "My Application", "My application", ["dev", "staging", "prod"]
+            portfolio.owner,
+            portfolio,
+            "My Application",
+            "My application",
+            ["dev", "staging", "prod"],
         )
 
     admin = UserFactory.create()
@@ -109,7 +117,11 @@ def test_scoped_portfolio_returns_all_applications_for_portfolio_owner(
 ):
     for _ in range(5):
         Applications.create(
-            portfolio, "My Application", "My application", ["dev", "staging", "prod"]
+            portfolio.owner,
+            portfolio,
+            "My Application",
+            "My application",
+            ["dev", "staging", "prod"],
         )
 
     scoped_portfolio = Portfolios.get(portfolio_owner, portfolio.id)