pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tests

Browse Source
This commit is contained in:
richard-dds 2018-08-14 15:29:55 -04:00
parent c6618c503b
commit ee207f163c
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
atst/forms/poc.py
View File

@ -9,6 +9,8 @@ class POCForm(ValidatedForm):
def validate(self, *args, **kwargs): def validate(self, *args, **kwargs):
if self.am_poc.data == "yes": if self.am_poc.data == "yes":
# Prepend Optional validators so that the validation chain
# halts if no data exists.
self.fname_poc.validators.insert(0, Optional()) self.fname_poc.validators.insert(0, Optional())
self.lname_poc.validators.insert(0, Optional()) self.lname_poc.validators.insert(0, Optional())
self.email_poc.validators.insert(0, Optional()) self.email_poc.validators.insert(0, Optional())

23
tests/routes/test_request_new.py
View File

@ -125,22 +125,21 @@ def test_not_am_poc_requires_poc_info_to_be_completed(client, user_session):
"/requests/new/3/{}".format(request.id), "/requests/new/3/{}".format(request.id),
headers={"Content-Type": "application/x-www-form-urlencoded"}, headers={"Content-Type": "application/x-www-form-urlencoded"},
data="am_poc=no", data="am_poc=no",
follow_redirects=True
) )
assert ERROR_CLASS in response.data.decode() assert ERROR_CLASS in response.data.decode()
# def test_not_am_poc_allows_user_to_fill_in_poc_info(client, user_session): def test_not_am_poc_allows_user_to_fill_in_poc_info(client, user_session):
# creator = UserFactory.create() creator = UserFactory.create()
# user_session(creator) user_session(creator)
# request = RequestFactory.create(creator=creator, body={}) request = RequestFactory.create(creator=creator, body={})
# client.post( response = client.post(
# "/requests/new/3/{}".format(request.id), "/requests/new/3/{}".format(request.id),
# headers={"Content-Type": "application/x-www-form-urlencoded"}, headers={"Content-Type": "application/x-www-form-urlencoded"},
# data="am_poc=yes", data="am_poc=no&fname_poc=test&lname_poc=user&email_poc=test.user@mail.com&dodid_poc=1234567890",
# ) )
assert ERROR_CLASS not in response.data.decode()
# assert "Location" not in response.headers
# request = Requests.get(request.id)
def test_can_review_data(user_session, client): def test_can_review_data(user_session, client):