From edbcfb5f04479a539802c3a3b92c6ab78afce820 Mon Sep 17 00:00:00 2001 From: dandds Date: Thu, 13 Sep 2018 09:45:22 -0400 Subject: [PATCH] review tabs for financial verification --- atst/domain/requests/requests.py | 4 ++++ atst/routes/requests/index.py | 6 ++--- atst/routes/requests/requests_form.py | 11 ++++++--- .../requests/financial_verification.html | 4 ++++ templates/requests/review_menu.html | 23 +++++++++++++++++++ templates/requests/view_pending.html | 15 ++++++++---- 6 files changed, 52 insertions(+), 11 deletions(-) create mode 100644 templates/requests/review_menu.html diff --git a/atst/domain/requests/requests.py b/atst/domain/requests/requests.py index b2f43a64..bdb05dbc 100644 --- a/atst/domain/requests/requests.py +++ b/atst/domain/requests/requests.py @@ -151,6 +151,10 @@ class Requests(object): def is_pending_ccpo_approval(cls, request): return request.status == RequestStatus.PENDING_CCPO_APPROVAL + @classmethod + def is_pending_ccpo_action(cls, request): + return Requests.is_pending_ccpo_acceptance(request) or Requests.is_pending_ccpo_approval(request) + @classmethod def status_count(cls, status, creator=None): return RequestsQuery.status_count(status, creator) diff --git a/atst/routes/requests/index.py b/atst/routes/requests/index.py index 5f7bf1cf..c55890dd 100644 --- a/atst/routes/requests/index.py +++ b/atst/routes/requests/index.py @@ -66,10 +66,8 @@ class RequestsIndex(object): return url_for( "requests.financial_verification", request_id=request.id, extended=True ) - elif Requests.is_pending_ccpo_acceptance( - request - ) or Requests.is_pending_ccpo_approval(request): - return url_for("requests.view_pending_request", request_id=request.id) + elif Requests.is_pending_ccpo_action(request): + return url_for("requests.view_request_details", request_id=request.id) else: return url_for( "requests.requests_form_update", screen=1, request_id=request.id diff --git a/atst/routes/requests/requests_form.py b/atst/routes/requests/requests_form.py index 0aef5fec..7a2b95c5 100644 --- a/atst/routes/requests/requests_form.py +++ b/atst/routes/requests/requests_form.py @@ -124,7 +124,12 @@ def requests_submit(request_id=None): return redirect("/requests?modal=pendingCCPOApproval") -@requests_bp.route("/requests/pending/", methods=["GET"]) -def view_pending_request(request_id=None): +@requests_bp.route("/requests/details/", methods=["GET"]) +def view_request_details(request_id=None): request = Requests.get(g.current_user, request_id) - return render_template("requests/view_pending.html", data=request.body) + return render_template( + "requests/view_pending.html", + data=request.body, + request_id=request.id, + pending_review=Requests.is_pending_ccpo_action(request) + ) diff --git a/templates/requests/financial_verification.html b/templates/requests/financial_verification.html index 25837927..74b2ff72 100644 --- a/templates/requests/financial_verification.html +++ b/templates/requests/financial_verification.html @@ -6,6 +6,10 @@ {% block content %} +{% with complete=False %} + {% include 'requests/review_menu.html' %} +{% endwith %} +
diff --git a/templates/requests/review_menu.html b/templates/requests/review_menu.html new file mode 100644 index 00000000..e8cf6d85 --- /dev/null +++ b/templates/requests/review_menu.html @@ -0,0 +1,23 @@ +{% set pending_url=url_for('requests.view_request_details', request_id=request_id) %} +{% set financial_url=url_for('requests.financial_verification', request_id=request_id) %} +
+ +
diff --git a/templates/requests/view_pending.html b/templates/requests/view_pending.html index 302b439b..ddde2d55 100644 --- a/templates/requests/view_pending.html +++ b/templates/requests/view_pending.html @@ -4,10 +4,17 @@ {% block content %}
- {{ Alert('Your request is being reviewed', - message="

You cannot edit your submitted request while it is under review. Your request will be reviewed within 3 business days.

", - level='warning' - ) }} + + {% with complete=False %} + {% include 'requests/review_menu.html' %} + {% endwith %} + + {% if pending_review %} + {{ Alert('Your request is being reviewed', + message="

You cannot edit your submitted request while it is under review. Your request will be reviewed within 3 business days.

", + level='warning' + ) }} + {% endif %}