Merge pull request #1028 from dod-ccpo/disabled-save-button-functionality

Use Disabled save button functionality across the site

templates/fragments/admin/add_new_portfolio_member.html

@@ -21,23 +21,23 @@
   </div>
   <div class='form-row'>
     <div class='form-col form-col--half'>
-      {{ TextInput(member_form.user_data.first_name, validation='requiredField') }}
+      {{ TextInput(member_form.user_data.first_name, validation='requiredField', optional=False) }}
     </div>
     <div class='form-col form-col--half'>
-      {{ TextInput(member_form.user_data.last_name, validation='requiredField') }}
+      {{ TextInput(member_form.user_data.last_name, validation='requiredField', optional=False) }}
     </div>
   </div>
   <div class='form-row'>
     <div class='form-col form-col--half'>
-      {{ TextInput(member_form.user_data.email, validation='email') }}
+      {{ TextInput(member_form.user_data.email, validation='email', optional=False) }}
     </div>
     <div class='form-col form-col--half'>
-      {{ TextInput(member_form.user_data.phone_number, validation='usPhone', optional=True) }}
+      {{ TextInput(member_form.user_data.phone_number, validation='usPhone') }}
     </div>
   </div>
   <div class='form-row'>
     <div class='form-col form-col--half'>
-      {{ TextInput(member_form.user_data.dod_id, validation='dodId') }}
+      {{ TextInput(member_form.user_data.dod_id, validation='dodId', optional=False) }}
     </div>
     <div class='form-col form-col--half'>
     </div>

templates/fragments/applications/edit_environment_team_form.html

@@ -81,7 +81,7 @@
           <div class='action-group'>
             {{
               SaveButton(
-                text=("portfolios.applications.update_button_text" | translate)
+                text=("common.save" | translate)
               )
             }}
           </div>

templates/fragments/applications/edit_environments.html

@@ -90,7 +90,7 @@
                     {{ TextInput(edit_form.name, validation='requiredField') }}
                     {{
                       SaveButton(
-                        text=("portfolios.applications.update_button_text" | translate)
+                        text=("common.save" | translate)
                       )
                     }}
                   </form>

templates/fragments/applications/new_member_modal_content.html

@@ -8,15 +8,15 @@
   </div>
   <div class='form-row'>
     <div class='form-col form-col--half'>
-      {{ TextInput(new_member_form.user_data.first_name, validation='requiredField') }}
+      {{ TextInput(new_member_form.user_data.first_name, validation='requiredField', optional=False) }}
     </div>
     <div class='form-col form-col--half'>
-      {{ TextInput(new_member_form.user_data.last_name, validation='requiredField') }}
+      {{ TextInput(new_member_form.user_data.last_name, validation='requiredField', optional=False) }}
     </div>
   </div>
   <div class='form-row'>
     <div class='form-col form-col--half'>
-      {{ TextInput(new_member_form.user_data.email, validation='email') }}
+      {{ TextInput(new_member_form.user_data.email, validation='email', optional=False) }}
     </div>
     <div class='form-col form-col--half'>
       {{ TextInput(new_member_form.user_data.phone_number, validation='usPhone', optional=True) }}
@@ -24,7 +24,7 @@
   </div>
   <div class='form-row'>
     <div class='form-col form-col--half'>
-      {{ TextInput(new_member_form.user_data.dod_id, validation='dodId') }}
+      {{ TextInput(new_member_form.user_data.dod_id, validation='dodId', optional=False) }}
     </div>
     <div class='form-col form-col--half'>
     </div>

templates/portfolios/applications/new.html

@@ -43,7 +43,7 @@
           </p>
           <div class="form-row">
             <div class="form-col form-col--two-thirds">
-              {{ TextInput(form.name) }}
+              {{ TextInput(form.name, optional=False) }}
             </div>
             <div class="form-col form-col--third">
               &nbsp;
@@ -51,7 +51,7 @@
           </div>
           <div class="form-row">
             <div class="form-col form-col--two-thirds">
-              {{ TextInput(form.description, paragraph=True) }}
+              {{ TextInput(form.description, paragraph=True, optional=False) }}
             </div>
             <div class="form-col form-col--third">
               &nbsp;

templates/portfolios/applications/settings.html

@@ -5,6 +5,7 @@
 {% from "components/icon.html" import Icon %}
 {% from "components/modal.html" import Modal %}
 {% from "components/pagination.html" import Pagination %}
+{% from "components/save_button.html" import SaveButton %}
 {% from "components/text_input.html" import TextInput %}
 
 {% set secondary_breadcrumb = 'portfolios.applications.existing_application_title' | translate({ "application_name": application.name }) %}
@@ -14,40 +15,42 @@
   <div class='subheading'>{{ 'portfolios.applications.settings_heading' | translate }}</div>
 
   {% if user_can(permissions.EDIT_APPLICATION) %}
-    <form method="POST" action="{{ url_for('applications.update', application_id=application.id) }}">
+    <base-form inline-template>
-      <div class="panel">
+      <form method="POST" action="{{ url_for('applications.update', application_id=application.id) }}">
-        <div class="panel__content">
+        <div class="panel">
-          {{ application_form.csrf_token }}
+          <div class="panel__content">
-          <p>
+            {{ application_form.csrf_token }}
-            {{ "fragments.edit_application_form.explain" | translate }}
+            <p>
-          </p>
+              {{ "fragments.edit_application_form.explain" | translate }}
-          <div class="form-row">
+            </p>
-            <div class="form-col form-col--two-thirds">
+            <div class="form-row">
-              {{ TextInput(application_form.name) }}
+              <div class="form-col form-col--two-thirds">
-              {{ TextInput(application_form.description, paragraph=True) }}
+                {{ TextInput(application_form.name) }}
+                {{ TextInput(application_form.description, paragraph=True) }}
+              </div>
+              <div class="form-col form-col--third">
+                {% if user_can(permissions.DELETE_APPLICATION) %}
+                  <div class="usa-input">
+                    <input
+                      id="delete-application"
+                      type="button"
+                      v-on:click="openModal('delete-application')"
+                      class='usa-button button-danger-outline'
+                      value="{{ 'portfolios.applications.delete.button' | translate }}"
+                      >
+                  </div>
+                {% endif %}
+              </div>
             </div>
-            <div class="form-col form-col--third">
+          </div>
-              {% if user_can(permissions.DELETE_APPLICATION) %}
+          <div class="panel__footer">
-                <div class="usa-input">
+            <div class="action-group">
-                  <input
+              {{ SaveButton('common.save'|translate) }}
-                    id="delete-application"
-                    type="button"
-                    v-on:click="openModal('delete-application')"
-                    class='usa-button button-danger-outline'
-                    value="{{ 'portfolios.applications.delete.button' | translate }}"
-                    >
-                </div>
-              {% endif %}
             </div>
           </div>
         </div>
-        <div class="panel__footer">
+      </form>
-          <div class="action-group">
+    </base-form>
-            <button class="usa-button usa-button-primary" tabindex="0" type="submit">{{ 'portfolios.applications.update_button_text' | translate }}</button>
-          </div>
-        </div>
-      </div>
-    </form>
   {% else %}
     <div class="panel">
       <div class="panel__content">

translations.yaml

@@ -325,7 +325,6 @@ portfolios:
       title: '{application_name} Team Settings'
       add_to_environment: Add to existing environment
     team_text: Team
-    update_button_text: Save
     members:
       new:
         assign_roles: Assign Member Environments and Roles