From d53400ee79af00d5ea162898b82602a0e39e2286 Mon Sep 17 00:00:00 2001 From: Montana Date: Fri, 11 Jan 2019 11:30:52 -0500 Subject: [PATCH 1/2] Fix invites bug that used a method without all the needed arguments --- atst/routes/task_orders/invite.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/atst/routes/task_orders/invite.py b/atst/routes/task_orders/invite.py index c43f14b5..dc044309 100644 --- a/atst/routes/task_orders/invite.py +++ b/atst/routes/task_orders/invite.py @@ -1,4 +1,4 @@ -from flask import redirect, url_for +from flask import redirect, url_for, g from . import task_orders_bp from atst.domain.task_orders import TaskOrders @@ -8,7 +8,7 @@ from atst.utils.flash import formatted_flash as flash # TODO: add a real implementation for this @task_orders_bp.route("/task_orders/invite/", methods=["POST"]) def invite(task_order_id): - task_order = TaskOrders.get(task_order_id) + task_order = TaskOrders.get(g.current_user, task_order_id) flash("task_order_submitted", task_order=task_order) return redirect( url_for("workspaces.workspace_members", workspace_id=task_order.workspace.id) From e0d9bd033593cf0e54911ef9dae4403409c56654 Mon Sep 17 00:00:00 2001 From: Montana Date: Fri, 11 Jan 2019 13:21:42 -0500 Subject: [PATCH 2/2] Add test for TO invite route --- atst/routes/task_orders/invite.py | 1 - tests/routes/task_orders/test_invite.py | 11 +++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 tests/routes/task_orders/test_invite.py diff --git a/atst/routes/task_orders/invite.py b/atst/routes/task_orders/invite.py index dc044309..78e2daf5 100644 --- a/atst/routes/task_orders/invite.py +++ b/atst/routes/task_orders/invite.py @@ -5,7 +5,6 @@ from atst.domain.task_orders import TaskOrders from atst.utils.flash import formatted_flash as flash -# TODO: add a real implementation for this @task_orders_bp.route("/task_orders/invite/", methods=["POST"]) def invite(task_order_id): task_order = TaskOrders.get(g.current_user, task_order_id) diff --git a/tests/routes/task_orders/test_invite.py b/tests/routes/task_orders/test_invite.py new file mode 100644 index 00000000..39cfeb76 --- /dev/null +++ b/tests/routes/task_orders/test_invite.py @@ -0,0 +1,11 @@ +import pytest +from flask import url_for + +from tests.factories import TaskOrderFactory + + +def test_invite(client): + to = TaskOrderFactory.create() + response = client.post( + url_for("task_orders.invite", task_order_id=to.id), follow_redirects=False + )