Just return a boolean response rather than a string
This commit is contained in:
parent
1024ee0cf2
commit
eafb000d58
@ -213,11 +213,11 @@ def pdf_signature_validations(pdf=None, crl_check=None):
|
||||
response["signatures"].append(sig)
|
||||
|
||||
if not sig["is_valid"]:
|
||||
response["result"] = "FAILURE"
|
||||
elif response["result"] is not "FAILURE":
|
||||
response["result"] = "OK"
|
||||
response["result"] = False
|
||||
elif response["result"] is not False:
|
||||
response["result"] = True
|
||||
|
||||
if len(signatures) == 0:
|
||||
response["result"] = "FAILURE"
|
||||
response["result"] = False
|
||||
|
||||
return response
|
||||
|
@ -22,7 +22,7 @@ def test_unsigned_pdf(crl_check):
|
||||
unsigned_pdf = open("tests/fixtures/sample.pdf", "rb").read()
|
||||
result = pdf_signature_validations(pdf=unsigned_pdf, crl_check=crl_check)
|
||||
|
||||
assert result == {"result": "FAILURE", "signature_count": 0, "signatures": []}
|
||||
assert result == {"result": False, "signature_count": 0, "signatures": []}
|
||||
|
||||
|
||||
def test_valid_signed_pdf(crl_check):
|
||||
@ -30,7 +30,7 @@ def test_valid_signed_pdf(crl_check):
|
||||
result = pdf_signature_validations(pdf=valid_signed_pdf, crl_check=crl_check)
|
||||
|
||||
assert result == {
|
||||
"result": "OK",
|
||||
"result": True,
|
||||
"signature_count": 2,
|
||||
"signatures": [
|
||||
{
|
||||
@ -63,7 +63,7 @@ def test_signed_pdf_thats_been_modified(crl_check):
|
||||
result = pdf_signature_validations(pdf=modified_pdf, crl_check=crl_check)
|
||||
|
||||
assert result == {
|
||||
"result": "FAILURE",
|
||||
"result": False,
|
||||
"signature_count": 2,
|
||||
"signatures": [
|
||||
{
|
||||
@ -98,7 +98,7 @@ def test_signed_pdf_dod_revoked(crl_check):
|
||||
result = pdf_signature_validations(pdf=signed_pdf_dod_revoked, crl_check=crl_check)
|
||||
|
||||
assert result == {
|
||||
"result": "FAILURE",
|
||||
"result": False,
|
||||
"signature_count": 1,
|
||||
"signatures": [
|
||||
{
|
||||
@ -123,7 +123,7 @@ def test_signed_dod_pdf_signer_cert_expired(crl_check):
|
||||
result = pdf_signature_validations(pdf=signed_pdf_dod_revoked, crl_check=crl_check)
|
||||
|
||||
assert result == {
|
||||
"result": "FAILURE",
|
||||
"result": False,
|
||||
"signature_count": 1,
|
||||
"signatures": [
|
||||
{
|
||||
|
Loading…
x
Reference in New Issue
Block a user