Make test more robust

This commit is contained in:
Montana 2019-04-04 08:38:52 -04:00
parent a5848877ae
commit ea2338bc30

View File

@ -182,18 +182,20 @@ def test_user_can_access_decorator_logs_access(
monkeypatch.setattr( monkeypatch.setattr(
"atst.domain.authz.decorator.check_access", lambda *a, **k: True "atst.domain.authz.decorator.check_access", lambda *a, **k: True
) )
num_msgs = len(mock_logger.messages)
_do_something() _do_something()
assert len(mock_logger.messages) == 2 assert len(mock_logger.messages) == num_msgs + 1
assert "accessed" in mock_logger.messages[1] assert "accessed" in mock_logger.messages[-1]
assert "GET" in mock_logger.messages[1] assert "GET" in mock_logger.messages[-1]
def _unauthorized(*a, **k): def _unauthorized(*a, **k):
raise UnauthorizedError(user, "do something") raise UnauthorizedError(user, "do something")
monkeypatch.setattr("atst.domain.authz.decorator.check_access", _unauthorized) monkeypatch.setattr("atst.domain.authz.decorator.check_access", _unauthorized)
num_msgs = len(mock_logger.messages)
with pytest.raises(UnauthorizedError): with pytest.raises(UnauthorizedError):
_do_something() _do_something()
assert len(mock_logger.messages) == 3 assert len(mock_logger.messages) == num_msgs + 1
assert "denied access" in mock_logger.messages[2] assert "denied access" in mock_logger.messages[-1]
assert "GET" in mock_logger.messages[2] assert "GET" in mock_logger.messages[-1]