Create Request.creator relationship

- Rename creator_id to user_id

tests/domain/test_requests.py

@@ -5,7 +5,7 @@ from atst.domain.exceptions import NotFoundError
 from atst.domain.requests import Requests
 from atst.models.request_status_event import RequestStatus
 
-from tests.factories import RequestFactory
+from tests.factories import RequestFactory, UserFactory
 
 
 @pytest.fixture(scope="function")
@@ -25,7 +25,7 @@ def test_nonexistent_request_raises():
 
 
 def test_new_request_has_started_status():
-    request = Requests.create(uuid4(), {})
+    request = Requests.create(UserFactory.build(), {})
     assert request.status == RequestStatus.STARTED
 
 

tests/factories.py

@@ -9,31 +9,6 @@ from atst.models.user import User
 from atst.models.role import Role
 
 
-class RequestStatusFactory(factory.alchemy.SQLAlchemyModelFactory):
-    class Meta:
-        model = RequestStatusEvent
-
-
-class RequestFactory(factory.alchemy.SQLAlchemyModelFactory):
-    class Meta:
-        model = Request
-
-    id = factory.Sequence(lambda x: uuid4())
-    status_events = factory.RelatedFactory(
-        RequestStatusFactory, "request", new_status=RequestStatus.STARTED
-    )
-
-
-class PENumberFactory(factory.alchemy.SQLAlchemyModelFactory):
-    class Meta:
-        model = PENumber
-
-
-class TaskOrderFactory(factory.alchemy.SQLAlchemyModelFactory):
-    class Meta:
-        model = TaskOrder
-
-
 class RoleFactory(factory.alchemy.SQLAlchemyModelFactory):
     class Meta:
         model = Role
@@ -50,3 +25,29 @@ class UserFactory(factory.alchemy.SQLAlchemyModelFactory):
     first_name = "Fake"
     last_name = "User"
     atat_role = factory.SubFactory(RoleFactory)
+
+
+class RequestStatusFactory(factory.alchemy.SQLAlchemyModelFactory):
+    class Meta:
+        model = RequestStatusEvent
+
+
+class RequestFactory(factory.alchemy.SQLAlchemyModelFactory):
+    class Meta:
+        model = Request
+
+    id = factory.Sequence(lambda x: uuid4())
+    status_events = factory.RelatedFactory(
+        RequestStatusFactory, "request", new_status=RequestStatus.STARTED
+    )
+    creator = factory.SubFactory(UserFactory)
+
+
+class PENumberFactory(factory.alchemy.SQLAlchemyModelFactory):
+    class Meta:
+        model = PENumber
+
+
+class TaskOrderFactory(factory.alchemy.SQLAlchemyModelFactory):
+    class Meta:
+        model = TaskOrder

tests/models/test_requests.py

@@ -1,4 +1,4 @@
-from tests.factories import RequestFactory
+from tests.factories import RequestFactory, UserFactory
 from atst.domain.requests import Requests, RequestStatus
 
 
@@ -19,3 +19,10 @@ def test_pending_ccpo_approval_requires_ccpo():
     request = Requests.set_status(request, RequestStatus.PENDING_CCPO_APPROVAL)
 
     assert Requests.action_required_by(request) == "ccpo"
+
+
+def test_request_has_creator():
+    user = UserFactory.create()
+    request = RequestFactory.create(creator=user)
+
+    assert request.creator == user