Fix some LGTM errors

atst/routes/applications/__init__.py

@@ -1,18 +1,14 @@
-from flask import Blueprint, current_app as app, g, redirect, url_for
-
-applications_bp = Blueprint("applications", __name__)
+from flask import current_app as app, g, redirect, url_for
 
 from . import index
 from . import new
 from . import settings
 from . import invitations
+from .blueprint import applications_bp
 from atst.domain.environment_roles import EnvironmentRoles
 from atst.domain.exceptions import UnauthorizedError
 from atst.domain.authz.decorator import user_can_access_decorator as user_can
 from atst.models.permissions import Permissions
-from atst.utils.context_processors import portfolio as portfolio_context_processor
-
-applications_bp.context_processor(portfolio_context_processor)
 
 
 def wrap_environment_role_lookup(user, environment_id=None, **kwargs):

atst/routes/applications/blueprint.py

@@ -0,0 +1,6 @@
+from flask import Blueprint
+
+from atst.utils.context_processors import portfolio as portfolio_context_processor
+
+applications_bp = Blueprint("applications", __name__)
+applications_bp.context_processor(portfolio_context_processor)

atst/routes/applications/index.py

@@ -1,6 +1,6 @@
 from flask import render_template
 
-from . import applications_bp
+from .blueprint import applications_bp
 from atst.domain.authz.decorator import user_can_access_decorator as user_can
 from atst.models.permissions import Permissions
 

atst/routes/applications/invitations.py

@@ -1,6 +1,6 @@
 from flask import redirect, url_for, g
 
-from . import applications_bp
+from .blueprint import applications_bp
 from atst.domain.invitations import ApplicationInvitations
 
 

atst/routes/applications/new.py

@@ -1,6 +1,6 @@
 from flask import redirect, render_template, request as http_request, url_for, g
 
-from . import applications_bp
+from .blueprint import applications_bp
 from atst.domain.applications import Applications
 from atst.domain.portfolios import Portfolios
 from atst.forms.application import NameAndDescriptionForm, EnvironmentsForm

atst/routes/applications/settings.py

@@ -1,6 +1,6 @@
 from flask import redirect, render_template, request as http_request, url_for, g
 
-from . import applications_bp
+from .blueprint import applications_bp
 from atst.domain.exceptions import AlreadyExistsError
 from atst.domain.environments import Environments
 from atst.domain.applications import Applications

atst/routes/portfolios/__init__.py

@@ -1,12 +1,7 @@
-from flask import Blueprint, request as http_request, g, render_template
+from flask import request as http_request, g, render_template
 from operator import attrgetter
 
-portfolios_bp = Blueprint("portfolios", __name__)
-
 from . import index
 from . import invitations
 from . import admin
-from atst.utils.context_processors import portfolio as portfolio_context_processor
-
-
-portfolios_bp.context_processor(portfolio_context_processor)
+from .blueprint import portfolios_bp

atst/routes/portfolios/admin.py

@@ -1,6 +1,6 @@
 from flask import render_template, request as http_request, g, redirect, url_for
 
-from . import portfolios_bp
+from .blueprint import portfolios_bp
 from atst.domain.portfolios import Portfolios
 from atst.domain.portfolio_roles import PortfolioRoles
 from atst.models.portfolio_role import Status as PortfolioRoleStatus

atst/routes/portfolios/blueprint.py

@@ -0,0 +1,5 @@
+from flask import Blueprint
+from atst.utils.context_processors import portfolio as portfolio_context_processor
+
+portfolios_bp = Blueprint("portfolios", __name__)
+portfolios_bp.context_processor(portfolio_context_processor)

atst/routes/portfolios/index.py

@@ -2,7 +2,7 @@ from datetime import date, timedelta
 
 from flask import redirect, render_template, url_for, request as http_request, g
 
-from . import portfolios_bp
+from .blueprint import portfolios_bp
 from atst.forms.portfolio import PortfolioCreationForm
 from atst.domain.reports import Reports
 from atst.domain.portfolios import Portfolios

atst/routes/portfolios/invitations.py

@@ -1,6 +1,6 @@
 from flask import g, redirect, url_for, render_template, request as http_request
 
-from . import portfolios_bp
+from .blueprint import portfolios_bp
 from atst.domain.authz.decorator import user_can_access_decorator as user_can
 from atst.domain.exceptions import AlreadyExistsError
 from atst.domain.invitations import PortfolioInvitations

atst/routes/task_orders/__init__.py

@@ -1,10 +1,4 @@
-from flask import Blueprint
-
-task_orders_bp = Blueprint("task_orders", __name__)
-
 from . import index
 from . import new
 from . import downloads
-from atst.utils.context_processors import portfolio as portfolio_context_processor
-
-task_orders_bp.context_processor(portfolio_context_processor)
+from .blueprint import task_orders_bp

atst/routes/task_orders/blueprint.py

@@ -0,0 +1,5 @@
+from flask import Blueprint
+from atst.utils.context_processors import portfolio as portfolio_context_processor
+
+task_orders_bp = Blueprint("task_orders", __name__)
+task_orders_bp.context_processor(portfolio_context_processor)

atst/routes/task_orders/downloads.py

@@ -1,6 +1,6 @@
 from flask import Response, current_app as app
 
-from . import task_orders_bp
+from .blueprint import task_orders_bp
 from atst.domain.task_orders import TaskOrders
 from atst.domain.exceptions import NotFoundError
 from atst.domain.authz.decorator import user_can_access_decorator as user_can

atst/routes/task_orders/index.py

@@ -1,6 +1,6 @@
 from flask import g, render_template, url_for, redirect
 
-from . import task_orders_bp
+from .blueprint import task_orders_bp
 from atst.domain.authz.decorator import user_can_access_decorator as user_can
 from atst.domain.portfolios import Portfolios
 from atst.domain.task_orders import TaskOrders

atst/routes/task_orders/new.py

@@ -8,7 +8,7 @@ from flask import (
     jsonify,
 )
 
-from . import task_orders_bp
+from .blueprint import task_orders_bp
 from atst.domain.authz.decorator import user_can_access_decorator as user_can
 from atst.domain.exceptions import NoAccessError
 from atst.domain.task_orders import TaskOrders