pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove old task order edit and update routes

Browse Source
This commit is contained in:
leigh-mil
2019-07-16 15:33:17 -04:00
parent b9e14f8719
commit e3c6b08d34
6 changed files with 71 additions and 596 deletions
Download Patch File Download Diff File Expand all files Collapse all files

91
tests/routes/task_orders/test_new.py
View File

@@ -115,29 +115,9 @@ def test_task_orders_confirm_signature(client, user_session, task_order):
assert response.status_code == 200
def test_task_orders_new_flow():
pass
def test_task_orders_save_incomplete(client, user_session, portfolio):
user_session(portfolio.owner)
form_data = {
"number": "0123456789",
"clins-0-jedi_clin_type": "JEDI_CLIN_1",
"clins-0-clin_number": "12312",
}
response = client.post(
url_for("task_orders.update", portfolio_id=portfolio.id), data=form_data
)
assert response.status_code == 302
task_order = portfolio.task_orders[0]
expected_url = url_for(
"task_orders.edit", task_order_id=task_order.id, _external=True
)
assert response.location == expected_url
def test_task_orders_add_pdf_existing_to(client, user_session, task_order):
def test_task_orders_form_step_one_add_pdf_existing_to(
client, user_session, task_order
):
user_session(task_order.creator)
response = client.get(url_for("task_orders.add_pdf", task_order_id=task_order.id))
assert response.status_code == 200
@@ -158,6 +138,17 @@ def test_task_orders_upload_pdf_existing_to(
assert task_order.pdf.filename == pdf_upload2.filename
def test_task_orders_upload_pdf_delete_pdf(client, user_session, portfolio, pdf_upload):
user_session(portfolio.owner)
task_order = TaskOrderFactory.create(pdf=pdf_upload, portfolio=portfolio)
data = {"pdf": ""}
response = client.post(
url_for("task_orders.upload_pdf", task_order_id=task_order.id), data=data
)
assert task_order.pdf is None
assert response.status_code == 302
def test_task_orders_update_number_existing_to(client, user_session, task_order):
user_session(task_order.creator)
form_data = {"number": "0000000000"}
@@ -210,24 +201,6 @@ def test_task_orders_update_clins_existing_to(client, user_session, task_order):
assert len(task_order.clins) == 1
def test_task_orders_update_existing_to(client, user_session, task_order):
user_session(task_order.creator)
form_data = {
"number": "0123456789",
"clins-0-jedi_clin_type": "JEDI_CLIN_1",
"clins-0-number": "12312",
"clins-0-start_date": "01/01/2020",
"clins-0-end_date": "01/01/2021",
"clins-0-obligated_amount": "5000",
"clins-0-loas-0": "123123123123",
}
response = client.post(
url_for("task_orders.update", task_order_id=task_order.id), data=form_data
)
assert response.status_code == 302
assert task_order.number == "0123456789"
@pytest.mark.skip(reason="Reevaluate how form handles invalid data")
def test_task_orders_update_invalid_data(client, user_session, portfolio):
user_session(portfolio.owner)
@@ -240,41 +213,7 @@ def test_task_orders_update_invalid_data(client, user_session, portfolio):
assert "There were some errors" in response.data.decode()
def test_task_orders_update(client, user_session, portfolio, pdf_upload):
user_session(portfolio.owner)
data = {"number": "0123456789", "pdf": pdf_upload}
task_order = TaskOrderFactory.create(number="0987654321", portfolio=portfolio)
response = client.post(
url_for("task_orders.update", task_order_id=task_order.id), data=data
)
assert task_order.number == data["number"]
assert response.status_code == 302
def test_task_orders_update_pdf(
client, user_session, portfolio, pdf_upload, pdf_upload2
):
user_session(portfolio.owner)
task_order = TaskOrderFactory.create(pdf=pdf_upload, portfolio=portfolio)
data = {"number": "0123456789", "pdf": pdf_upload2}
response = client.post(
url_for("task_orders.update", task_order_id=task_order.id), data=data
)
assert task_order.pdf.filename == pdf_upload2.filename
assert response.status_code == 302
def test_task_orders_update_delete_pdf(client, user_session, portfolio, pdf_upload):
user_session(portfolio.owner)
task_order = TaskOrderFactory.create(pdf=pdf_upload, portfolio=portfolio)
data = {"number": "0123456789", "pdf": ""}
response = client.post(
url_for("task_orders.update", task_order_id=task_order.id), data=data
)
assert task_order.pdf is None
assert response.status_code == 302
@pytest.mark.skip(reason="Reevaluate if user can see review page w/ incomplete TO")
def test_cannot_get_to_review_screen_with_incomplete_data(
client, user_session, portfolio
):

69
tests/test_access.py
View File

@@ -448,30 +448,67 @@ def test_task_orders_download_task_order_pdf_access(get_url_assert_status, monke
get_url_assert_status(rando, url, 404)
# task_orders.update
def test_task_orders_update_access(post_url_assert_status):
# task_orders.add_pdf
# task_orders.add_number
# task_orders.add_clins
# task_orders.review
# task_orders.confirm_signature
def test_task_orders_new_get_routes(get_url_assert_status):
get_routes = [
"task_orders.add_pdf",
"task_orders.add_number",
"task_orders.add_clins",
"task_orders.review",
"task_orders.confirm_signature",
]
ccpo = user_with(PermissionSets.EDIT_PORTFOLIO_FUNDING)
owner = user_with()
rando = user_with()
portfolio = PortfolioFactory.create(owner=owner)
data = {"number": 1234567890}
task_order = TaskOrderFactory.create(portfolio=portfolio, creator=owner)
url = url_for("task_orders.update", portfolio_id=portfolio.id)
post_url_assert_status(owner, url, 302, data=data)
post_url_assert_status(ccpo, url, 302, data=data)
post_url_assert_status(rando, url, 404, data=data)
for route in get_routes:
url = url_for(route, task_order_id=task_order.id)
task_order = TaskOrderFactory.create(portfolio=portfolio)
get_url_assert_status(ccpo, url, 200)
get_url_assert_status(owner, url, 200)
get_url_assert_status(rando, url, 404)
url = url_for("task_orders.update", task_order_id=task_order.id)
post_url_assert_status(owner, url, 302, data=data)
post_url_assert_status(ccpo, url, 302, data=data)
post_url_assert_status(rando, url, 404, data=data)
url = url_for("task_orders.update", portfolio_id=portfolio.id)
post_url_assert_status(owner, url, 302, data=data)
post_url_assert_status(ccpo, url, 302, data=data)
post_url_assert_status(rando, url, 404, data=data)
# task_orders.upload_pdf
# task_orders.update_number
# task_orders.update_clins
def test_task_orders_new_post_routes(post_url_assert_status):
post_routes = [
("task_orders.upload_pdf", {"pdf": ""}),
("task_orders.update_number", {"number": "1234567890"}),
(
"task_orders.update_clins",
{
"clins-0-jedi_clin_type": "JEDI_CLIN_1",
"clins-0-clin_number": "12312",
"clins-0-start_date": "01/01/2020",
"clins-0-end_date": "01/01/2021",
"clins-0-obligated_amount": "5000",
"clins-0-loas-0": "123123123123",
},
),
]
ccpo = user_with(PermissionSets.EDIT_PORTFOLIO_FUNDING)
owner = user_with()
rando = user_with()
portfolio = PortfolioFactory.create(owner=owner)
task_order = TaskOrderFactory.create(portfolio=portfolio, creator=owner)
for route, data in post_routes:
url = url_for(route, task_order_id=task_order.id)
post_url_assert_status(owner, url, 302, data=data)
post_url_assert_status(ccpo, url, 302, data=data)
post_url_assert_status(rando, url, 404, data=data)
def test_applications_application_team_access(get_url_assert_status):