pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't flash when cancelling TO form with invalid data

Browse Source
This commit is contained in:
richard-dds
2019-08-02 16:07:32 -04:00
parent 24049c4c81
commit e034269a02
3 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/routes/task_orders/test_new.py
View File

@@ -1,5 +1,5 @@
import pytest
from flask import url_for
from flask import url_for, get_flashed_messages
from datetime import timedelta, date
from atst.domain.task_orders import TaskOrders
@@ -342,9 +342,10 @@ def test_cancel_can_create_new_to(client, user_session, portfolio):
def test_cancel_edit_does_not_save_invalid_form_input(client, user_session, session):
task_order = TaskOrderFactory.create()
user_session(task_order.portfolio.owner)
bad_data = {"clins-0-jedi_clin_type": "foo"}
response = client.post(
url_for("task_orders.cancel_edit", task_order_id=task_order.id, save=True),
data={"clins": "not really clins"},
data=bad_data,
)
assert response.status_code == 302
@@ -353,6 +354,22 @@ def test_cancel_edit_does_not_save_invalid_form_input(client, user_session, sess
assert updated_task_order.clins == task_order.clins
def test_cancel_edit_on_invalid_input_does_not_flash(
app, client, user_session, session
):
task_order = TaskOrderFactory.create()
user_session(task_order.portfolio.owner)
bad_data = {"clins-0-jedi_clin_type": "foo"}
response = client.post(
url_for("task_orders.cancel_edit", task_order_id=task_order.id, save=True),
data=bad_data,
)
assert len(get_flashed_messages()) == 0
def test_cancel_edit_without_saving(client, user_session, session):
task_order = TaskOrderFactory.create(number=None)
user_session(task_order.portfolio.owner)