diff --git a/atst/routes/applications/team.py b/atst/routes/applications/team.py index be151916..03c489c3 100644 --- a/atst/routes/applications/team.py +++ b/atst/routes/applications/team.py @@ -80,13 +80,6 @@ def render_team_page(application): ) -@applications_bp.route("/applications//team") -@user_can(Permissions.VIEW_APPLICATION, message="view portfolio applications") -def team(application_id): - application = Applications.get(resource_id=application_id) - return render_team_page(application) - - @applications_bp.route("/application//team", methods=["POST"]) @user_can(Permissions.EDIT_APPLICATION_MEMBER, message="update application member") def update_team(application_id): @@ -115,7 +108,7 @@ def update_team(application_id): return redirect( url_for( - "applications.team", + "applications.settings", application_id=application_id, fragment="application-members", _anchor="application-members", @@ -172,7 +165,7 @@ def create_member(application_id): return redirect( url_for( - "applications.team", + "applications.settings", application_id=application_id, fragment="application-members", _anchor="application-members", @@ -197,7 +190,7 @@ def remove_member(application_id, application_role_id): return redirect( url_for( - "applications.team", + "applications.settings", _anchor="application-members", application_id=g.application.id, fragment="application-members", diff --git a/styles/sections/_application_edit.scss b/styles/sections/_application_edit.scss index 985b6956..89a56396 100644 --- a/styles/sections/_application_edit.scss +++ b/styles/sections/_application_edit.scss @@ -34,11 +34,6 @@ } } -.app-team-settings-link { - font-size: $small-font-size; - font-weight: $font-normal; -} - .environment-roles { padding: 0 ($gap * 3) ($gap * 3); diff --git a/templates/fragments/applications/edit_environment_team_form.html b/templates/fragments/applications/edit_environment_team_form.html index 3703b86a..88d55f47 100644 --- a/templates/fragments/applications/edit_environment_team_form.html +++ b/templates/fragments/applications/edit_environment_team_form.html @@ -4,12 +4,6 @@ {% for env_form in members_form.envs %} {% if env_form.env_id.data == env['id'] %} -
diff --git a/templates/portfolios/applications/index.html b/templates/portfolios/applications/index.html index 778cc40b..873078f5 100644 --- a/templates/portfolios/applications/index.html +++ b/templates/portfolios/applications/index.html @@ -51,12 +51,6 @@ {{ "portfolios.applications.app_settings_text" | translate }}
- - {{ "portfolios.applications.team_text" | translate }} ({{ application.members | length }}) - -
{% set has_environments = 0 < (application.environments|length) %} Environments ({{ application.environments|length }}) diff --git a/tests/routes/applications/test_team.py b/tests/routes/applications/test_team.py index 2ba80a9e..79d5e5d0 100644 --- a/tests/routes/applications/test_team.py +++ b/tests/routes/applications/test_team.py @@ -10,16 +10,6 @@ from atst.forms.data import ENV_ROLE_NO_ACCESS as NO_ACCESS from tests.factories import * -def test_application_team(client, user_session): - portfolio = PortfolioFactory.create() - application = ApplicationFactory.create(portfolio=portfolio) - - user_session(portfolio.owner) - - response = client.get(url_for("applications.team", application_id=application.id)) - assert response.status_code == 200 - - def test_update_team_permissions(client, user_session): application = ApplicationFactory.create() owner = application.portfolio.owner @@ -183,7 +173,7 @@ def test_create_member(monkeypatch, client, user_session, session): assert response.status_code == 302 expected_url = url_for( - "applications.team", + "applications.settings", application_id=application.id, fragment="application-members", _anchor="application-members", @@ -220,7 +210,7 @@ def test_remove_member_success(client, user_session): assert response.status_code == 302 assert response.location == url_for( - "applications.team", + "applications.settings", _anchor="application-members", _external=True, application_id=application.id, @@ -244,7 +234,7 @@ def test_remove_new_member_success(client, user_session): assert response.status_code == 302 assert response.location == url_for( - "applications.team", + "applications.settings", _anchor="application-members", _external=True, application_id=application.id, diff --git a/tests/test_access.py b/tests/test_access.py index 0d42c300..8a43b97a 100644 --- a/tests/test_access.py +++ b/tests/test_access.py @@ -585,20 +585,6 @@ def test_task_orders_new_post_routes(post_url_assert_status): post_url_assert_status(rando, url, 404, data=data) -def test_applications_application_team_access(get_url_assert_status): - ccpo = UserFactory.create_ccpo() - rando = UserFactory.create() - - portfolio = PortfolioFactory.create() - application = ApplicationFactory.create(portfolio=portfolio) - - url = url_for("applications.team", application_id=application.id) - - get_url_assert_status(ccpo, url, 200) - get_url_assert_status(portfolio.owner, url, 200) - get_url_assert_status(rando, url, 404) - - def test_portfolio_delete_access(post_url_assert_status): rando = UserFactory.create() owner = UserFactory.create()