pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use enum value to store status displayname

Browse Source
This commit is contained in:
richard-dds 2018-08-08 16:18:12 -04:00
parent d307a255b1
commit dd849df388
2 changed files with 49 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
atst/models/request_status_event.py
View File

@ -9,12 +9,12 @@ from atst.models.types import Id
class RequestStatus(Enum): class RequestStatus(Enum):
STARTED = "started" STARTED = "Started"
PENDING_FINANCIAL_VERIFICATION = "pending_financial_verification" PENDING_FINANCIAL_VERIFICATION = "Pending Financial Verification"
PENDING_CCPO_APPROVAL = "pending_ccpo_approval" PENDING_CCPO_APPROVAL = "Pending CCPO Approval"
APPROVED = "approved" APPROVED = "Approved"
EXPIRED = "expired" EXPIRED = "Expired"
DELETED = "deleted" DELETED = "Deleted"
class RequestStatusEvent(Base): class RequestStatusEvent(Base):
@ -32,4 +32,4 @@ class RequestStatusEvent(Base):
@property @property
def displayname(self): def displayname(self):
return self.new_status.name.replace("_", " ").title() return self.new_status.value

42
tests/models/test_requests.py
View File

@ -26,3 +26,45 @@ def test_request_has_creator():
request = RequestFactory.create(creator=user) request = RequestFactory.create(creator=user)
assert request.creator == user assert request.creator == user
def test_request_status_started_displayname():
request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.STARTED)
assert request.status_displayname == "Started"
def test_request_status_pending_financial_displayname():
request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.PENDING_FINANCIAL_VERIFICATION)
assert request.status_displayname == "Pending Financial Verification"
def test_request_status_pending_ccpo_displayname():
request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.PENDING_CCPO_APPROVAL)
assert request.status_displayname == "Pending CCPO Approval"
def test_request_status_pending_approved_displayname():
request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.APPROVED)
assert request.status_displayname == "Approved"
def test_request_status_pending_expired_displayname():
request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.EXPIRED)
assert request.status_displayname == "Expired"
def test_request_status_pending_deleted_displayname():
request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.DELETED)
assert request.status_displayname == "Deleted"