pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only flash when permissions change

Browse Source
This commit is contained in:
Montana 2019-03-29 12:01:15 -04:00
parent 2d7e17e522
commit d70332836b
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
atst/routes/portfolios/index.py
View File

@ -95,6 +95,7 @@ def portfolio_admin(portfolio_id):
def edit_portfolio_members(portfolio_id): def edit_portfolio_members(portfolio_id):
portfolio = Portfolios.get_for_update(portfolio_id) portfolio = Portfolios.get_for_update(portfolio_id)
member_perms_form = member_forms.MembersPermissionsForm(http_request.form) member_perms_form = member_forms.MembersPermissionsForm(http_request.form)
has_changed = False
for subform in member_perms_form.members_permissions: for subform in member_perms_form.members_permissions:
new_perm_set = subform.data["permission_sets"] new_perm_set = subform.data["permission_sets"]
@ -102,7 +103,9 @@ def edit_portfolio_members(portfolio_id):
portfolio_role = PortfolioRoles.get(portfolio.id, user_id) portfolio_role = PortfolioRoles.get(portfolio.id, user_id)
if portfolio_role.permission_sets != new_perm_set: if portfolio_role.permission_sets != new_perm_set:
PortfolioRoles.update(portfolio_role, new_perm_set) PortfolioRoles.update(portfolio_role, new_perm_set)
has_changed = True
if has_changed:
flash("update_portfolio_members", portfolio=portfolio) flash("update_portfolio_members", portfolio=portfolio)
return redirect( return redirect(
@ -111,6 +114,7 @@ def edit_portfolio_members(portfolio_id):
portfolio_id=portfolio.id, portfolio_id=portfolio.id,
fragment="portfolio-members", fragment="portfolio-members",
_anchor="portfolio-members", _anchor="portfolio-members",
has_changed=has_changed,
) )
) )

2
templates/fragments/admin/portfolio_members.html
View File

@ -3,7 +3,7 @@
<section class="member-list" id="portfolio-members"> <section class="member-list" id="portfolio-members">
<div class='responsive-table-wrapper panel'> <div class='responsive-table-wrapper panel'>
{% if g.matchesPath("portfolio-members") %} {% if g.matchesPath("portfolio-members") and has_changed %}
{% include "fragments/flash.html" %} {% include "fragments/flash.html" %}
{% endif %} {% endif %}
<form method='POST' id="member-perms" action='{{ url_for("portfolios.edit_portfolio_members", portfolio_id=portfolio.id) }}' autocomplete="off" enctype="multipart/form-data"> <form method='POST' id="member-perms" action='{{ url_for("portfolios.edit_portfolio_members", portfolio_id=portfolio.id) }}' autocomplete="off" enctype="multipart/form-data">