Merge pull request #1046 from dod-ccpo/tests-debug

Enable debug mode in tests.

tests/routes/portfolios/test_admin.py

@@ -1,5 +1,5 @@
 from flask import url_for
-from unittest.mock import Mock
+from unittest.mock import MagicMock
 
 from atst.domain.permission_sets import PermissionSets
 from atst.domain.portfolio_roles import PortfolioRoles
@@ -129,7 +129,7 @@ def test_rerender_admin_page_if_member_perms_form_does_not_validate(
         "members_permissions-0-perms_portfolio_mgmt": "view_portfolio_admin",
     }
 
-    mock_route = Mock()
+    mock_route = MagicMock(return_value=("", 200, {}))
     monkeypatch.setattr("atst.routes.portfolios.admin.render_admin_page", mock_route)
     client.post(
         url_for("portfolios.edit_members", portfolio_id=portfolio.id), data=form_data

tests/routes/portfolios/test_index.py

@@ -1,4 +1,5 @@
 from flask import url_for
+import pytest
 
 from tests.factories import (
     random_future_date,
@@ -9,7 +10,7 @@ from tests.factories import (
     UserFactory,
 )
 from atst.utils.localization import translate
-from atst.domain.portfolios import Portfolios
+from atst.domain.portfolios import Portfolios, PortfolioDeletionApplicationsExistError
 from atst.domain.portfolios.query import PortfoliosQuery
 
 
@@ -128,7 +129,7 @@ def test_delete_portfolio_success(client, user_session):
     assert len(Portfolios.for_user(user=owner)) == 0
 
 
-def test_delete_portfolio_failure(client, user_session):
+def test_delete_portfolio_failure(no_debug_client, user_session):
     portfolio = PortfolioFactory.create()
     application = ApplicationFactory.create(portfolio=portfolio)
     owner = portfolio.owner
@@ -136,7 +137,7 @@ def test_delete_portfolio_failure(client, user_session):
 
     assert len(Portfolios.for_user(user=owner)) == 1
 
-    response = client.post(
+    response = no_debug_client.post(
         url_for("portfolios.delete_portfolio", portfolio_id=portfolio.id)
     )
 

tests/routes/test_errors.py

@@ -1,6 +1,8 @@
 import pytest
 from flask import url_for
-from copy import copy
+
+from atst.app import make_config, make_app
+
 from tests.factories import UserFactory
 
 
@@ -24,14 +26,28 @@ def test_csrf_error(csrf_enabled_app, client):
     assert "Log in required" in body
 
 
-def test_errors_generate_notifications(app, client, user_session, notification_sender):
-    user_session(UserFactory.create())
-    new_app = copy(app)
+@pytest.fixture
+def blowup_app(notification_sender):
+    _blowup_app = make_app(make_config(direct_config={"DEBUG": False}))
+    _blowup_app.notification_sender = notification_sender
 
-    @new_app.route("/throw")
+    @_blowup_app.route("/throw")
     def throw():
         raise ValueError()
 
-    new_app.test_client().get("/throw")
+    yield _blowup_app
+
+
+@pytest.fixture
+def blowup_client(blowup_app):
+    yield blowup_app.test_client()
+
+
+def test_errors_generate_notifications(
+    blowup_client, client, user_session, notification_sender
+):
+    user_session(UserFactory.create())
+
+    blowup_client.get("/throw")
 
     notification_sender.send.assert_called_once()