wip

atst/services/invitation.py

@@ -5,43 +5,43 @@ from atst.queue import queue
 from atst.domain.task_orders import TaskOrders
 from atst.domain.portfolio_roles import PortfolioRoles
 
-OFFICER_INVITATIONS = [
-    {
-        "field": "ko_invite",
+OFFICER_INVITATIONS = {
+    "ko_invite": {
         "role": "contracting_officer",
         "subject": "Review a task order",
         "template": "emails/invitation.txt",
     },
-    {
-        "field": "cor_invite",
+    "cor_invite": {
         "role": "contracting_officer_representative",
         "subject": "Help with a task order",
         "template": "emails/invitation.txt",
     },
-    {
-        "field": "so_invite",
+    "so_invite": {
         "role": "security_officer",
         "subject": "Review security for a task order",
         "template": "emails/invitation.txt",
     },
-]
+}
 
 
 def update_officer_invitations(user, task_order):
-    for officer_type in OFFICER_INVITATIONS:
-        field = officer_type["field"]
-        if getattr(task_order, field) and not getattr(task_order, officer_type["role"]):
-            officer_data = task_order.officer_dictionary(officer_type["role"])
+    for invite_type in dict.keys(OFFICER_INVITATIONS):
+        invite_opts = OFFICER_INVITATIONS[invite_type]
+
+        if getattr(task_order, invite_type) and not getattr(
+            task_order, invite_opts["role"]
+        ):
+            officer_data = task_order.officer_dictionary(invite_opts["role"])
             officer = TaskOrders.add_officer(
-                user, task_order, officer_type["role"], officer_data
+                user, task_order, invite_opts["role"], officer_data
             )
             pf_officer_member = PortfolioRoles.get(task_order.portfolio.id, officer.id)
             invite_service = Invitation(
                 user,
                 pf_officer_member,
                 officer_data["email"],
-                subject=officer_type["subject"],
-                email_template=officer_type["template"],
+                subject=invite_opts["subject"],
+                email_template=invite_opts["template"],
             )
             invite_service.invite()