pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove update ppoc route from the blueprint and skip related tests

Browse Source
This commit is contained in:
leigh-mil 2020-01-08 15:55:10 -05:00
parent 81680c4ba4
commit d550b4108e
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
atst/routes/portfolios/admin.py
View File

@ -109,7 +109,8 @@ def admin(portfolio_id):
return render_admin_page(portfolio) return render_admin_page(portfolio)
@portfolios_bp.route("/portfolios/<portfolio_id>/update_ppoc", methods=["POST"]) # Updating PPoC is a post-MVP feature
# @portfolios_bp.route("/portfolios/<portfolio_id>/update_ppoc", methods=["POST"])
@user_can(Permissions.EDIT_PORTFOLIO_POC, message="update portfolio ppoc") @user_can(Permissions.EDIT_PORTFOLIO_POC, message="update portfolio ppoc")
def update_ppoc(portfolio_id): def update_ppoc(portfolio_id):
role_id = http_request.form.get("role_id") role_id = http_request.form.get("role_id")

9
tests/routes/portfolios/test_admin.py
View File

@ -1,3 +1,4 @@
import pytest
from flask import url_for from flask import url_for
from unittest.mock import MagicMock from unittest.mock import MagicMock
@ -24,6 +25,7 @@ def test_update_portfolio_name_and_description(client, user_session):
assert portfolio.description == "a portfolio for things" assert portfolio.description == "a portfolio for things"
@pytest.mark.skip(reason="Out of scope for MVP")
def updating_ppoc_successfully(client, old_ppoc, new_ppoc, portfolio): def updating_ppoc_successfully(client, old_ppoc, new_ppoc, portfolio):
response = client.post( response = client.post(
url_for("portfolios.update_ppoc", portfolio_id=portfolio.id, _external=True), url_for("portfolios.update_ppoc", portfolio_id=portfolio.id, _external=True),
@ -44,6 +46,7 @@ def updating_ppoc_successfully(client, old_ppoc, new_ppoc, portfolio):
assert Permissions.EDIT_PORTFOLIO_POC not in old_ppoc.permissions assert Permissions.EDIT_PORTFOLIO_POC not in old_ppoc.permissions
@pytest.mark.skip(reason="Out of scope for MVP")
def test_update_ppoc_no_user_id_specified(client, user_session): def test_update_ppoc_no_user_id_specified(client, user_session):
portfolio = PortfolioFactory.create() portfolio = PortfolioFactory.create()
@ -57,6 +60,7 @@ def test_update_ppoc_no_user_id_specified(client, user_session):
assert response.status_code == 404 assert response.status_code == 404
@pytest.mark.skip(reason="Out of scope for MVP")
def test_update_ppoc_to_member_not_on_portfolio(client, user_session): def test_update_ppoc_to_member_not_on_portfolio(client, user_session):
portfolio = PortfolioFactory.create() portfolio = PortfolioFactory.create()
original_ppoc = portfolio.owner original_ppoc = portfolio.owner
@ -74,6 +78,7 @@ def test_update_ppoc_to_member_not_on_portfolio(client, user_session):
assert portfolio.owner.id == original_ppoc.id assert portfolio.owner.id == original_ppoc.id
@pytest.mark.skip(reason="Out of scope for MVP")
def test_update_ppoc_when_ppoc(client, user_session): def test_update_ppoc_when_ppoc(client, user_session):
portfolio = PortfolioFactory.create() portfolio = PortfolioFactory.create()
original_ppoc = portfolio.owner_role original_ppoc = portfolio.owner_role
@ -90,7 +95,8 @@ def test_update_ppoc_when_ppoc(client, user_session):
) )
def test_update_ppoc_when_cpo(client, user_session): @pytest.mark.skip(reason="Out of scope for MVP")
def test_update_ppoc_when_ccpo(client, user_session):
ccpo = UserFactory.create_ccpo() ccpo = UserFactory.create_ccpo()
portfolio = PortfolioFactory.create() portfolio = PortfolioFactory.create()
original_ppoc = portfolio.owner_role original_ppoc = portfolio.owner_role
@ -107,6 +113,7 @@ def test_update_ppoc_when_cpo(client, user_session):
) )
@pytest.mark.skip(reason="Out of scope for MVP")
def test_update_ppoc_when_not_ppoc(client, user_session): def test_update_ppoc_when_not_ppoc(client, user_session):
portfolio = PortfolioFactory.create() portfolio = PortfolioFactory.create()
new_owner = UserFactory.create() new_owner = UserFactory.create()