From 810a39d359259782c0daded0de1ce3eddc58b1c9 Mon Sep 17 00:00:00 2001 From: Patrick Smith Date: Wed, 15 Aug 2018 07:50:58 -0400 Subject: [PATCH 1/3] Force tests to fail --- tests/test_basic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/test_basic.py b/tests/test_basic.py index 67df4c9f..54667fda 100644 --- a/tests/test_basic.py +++ b/tests/test_basic.py @@ -1,3 +1,6 @@ +def test_the_tester(): + assert False + def test_hello_world(client): response = client.get("/") assert response.status_code == 200 From a6cf27ef5f13d4df73059b43f3d0d60734f44dc3 Mon Sep 17 00:00:00 2001 From: Patrick Smith Date: Wed, 15 Aug 2018 08:05:01 -0400 Subject: [PATCH 2/3] Make tests run on CI Specify the entrypoint and cmd on the tester_image2 so that it runs tests. I was hoping to not have to duplicate the entrypoint and cmd here, but the results from `docker inspect ${TESTER_IMAGE1_NAME} -f "{{ .Config.Cmd }}"` were not suitable to pass back to `docker inspect` or `docker run`. --- .travis.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 5a0734c2..18732e28 100644 --- a/.travis.yml +++ b/.travis.yml @@ -32,7 +32,11 @@ before_script: script: - docker run -d --entrypoint='/bin/sh' -t --name current-atst-tester "${TESTER_IMAGE1_NAME}" - docker container exec -t current-atst-tester script/sync-crls - - docker commit current-atst-tester "${TESTER_IMAGE2_NAME}" + - docker commit + --change='ENTRYPOINT ["/usr/bin/dumb-init", "--"]' + --change='CMD ["bash", "-c", "${APP_DIR}/script/cibuild"]' + current-atst-tester + "${TESTER_IMAGE2_NAME}" - docker cp current-atst-tester:/opt/atat/atst/crl/. ./crl/ - docker container stop current-atst-tester - docker run --add-host "postgreshost:${postgres_ip}" --add-host "redishost:${redis_ip}" "${TESTER_IMAGE2_NAME}" From 747a8dbbd4ff1baef3ac00b91d17c76d898bb663 Mon Sep 17 00:00:00 2001 From: Patrick Smith Date: Thu, 16 Aug 2018 17:10:23 -0400 Subject: [PATCH 3/3] Revert "Force tests to fail" This reverts commit 810a39d359259782c0daded0de1ce3eddc58b1c9. --- tests/test_basic.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/test_basic.py b/tests/test_basic.py index 54667fda..67df4c9f 100644 --- a/tests/test_basic.py +++ b/tests/test_basic.py @@ -1,6 +1,3 @@ -def test_the_tester(): - assert False - def test_hello_world(client): response = client.get("/") assert response.status_code == 200