From d139c6678d4913ea2b7a861ba05aeca8af567530 Mon Sep 17 00:00:00 2001 From: dandds Date: Thu, 6 Sep 2018 10:58:12 -0400 Subject: [PATCH] set content-disposition for task order downloads so filename is known --- atst/routes/requests/approval.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/atst/routes/requests/approval.py b/atst/routes/requests/approval.py index fefea484..ddf34c38 100644 --- a/atst/routes/requests/approval.py +++ b/atst/routes/requests/approval.py @@ -36,8 +36,15 @@ def approval(request_id): def task_order_pdf_download(request_id): request = Requests.get(g.current_user, request_id) if request.task_order and request.task_order.pdf: - object_name = request.task_order.pdf.object_name - generator = app.uploader.download_stream(object_name) - return Response(generator, mimetype="application/pdf") + pdf = request.task_order.pdf + generator = app.uploader.download_stream(pdf.object_name) + return Response( + generator, + headers={ + "Content-Disposition": "attachment; filename={}".format(pdf.filename) + }, + mimetype="application/pdf", + ) + else: raise NotFoundError("task_order pdf")